-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure: mention that we search azure config #2703
Conversation
96cdabe
to
6c635f1
Compare
@@ -481,6 +481,12 @@ $ export AZURE_PASSWORD='mysecret' | |||
> [env vars](https://docs.microsoft.com/en-us/python/api/azure-identity/azure.identity.environmentcredential) | |||
> available. | |||
|
|||
Also some options can be propagated from the azure config file (which is managed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: some options
- what does it mean?
I think we should describe all possible source and their priorities at the very beginning of the section. No chances people will get to this last paragraph. And if I understand this correctly (this files serves the same role as AWS credentials), this seems to be an important information that we want and should mention from the very beginning.
Something like: there are a few ways to define config values, in the order of their priority:
- config files
- env
- DVC config
etc
(This is just an example, I don't know the details here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: some options - what does it mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! That comment if you put it somewhere at the top of the document would be better - it's explicit, it explains the order clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.
🐛 Please make sure to mention
Fix #issue
(if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.Please choose to allow us to edit your branch when creating the PR.
Thank you for the contribution - we'll try to review it as soon as possible. 🙏
See: #2485