Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: mention that we search azure config #2703

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Conversation

isidentical
Copy link
Contributor

@isidentical isidentical commented Aug 10, 2021

You may disregard these recommendations if you used the Edit on GitHub button from dvc.org to improve a doc in place.

❗ Please read the guidelines in the Contributing to the Documentation list if you make any substantial changes to the documentation or JS engine.

🐛 Please make sure to mention Fix #issue (if applicable) in the description of the PR. This causes GitHub to close it automatically when the PR is merged.

Please choose to allow us to edit your branch when creating the PR.

Thank you for the contribution - we'll try to review it as soon as possible. 🙏

See: #2485

@shcheklein shcheklein temporarily deployed to dvc-org-azure-config-di-4w9snq August 10, 2021 07:59 Inactive
@shcheklein shcheklein temporarily deployed to dvc-org-azure-config-di-4w9snq August 16, 2021 11:43 Inactive
@@ -481,6 +481,12 @@ $ export AZURE_PASSWORD='mysecret'
> [env vars](https://docs.microsoft.com/en-us/python/api/azure-identity/azure.identity.environmentcredential)
> available.

Also some options can be propagated from the azure config file (which is managed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: some options - what does it mean?


I think we should describe all possible source and their priorities at the very beginning of the section. No chances people will get to this last paragraph. And if I understand this correctly (this files serves the same role as AWS credentials), this seems to be an important information that we want and should mention from the very beginning.

Something like: there are a few ways to define config values, in the order of their priority:

  1. config files
  2. env
  3. DVC config

etc

(This is just an example, I don't know the details here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: some options - what does it mean?

#2703 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That comment if you put it somewhere at the top of the document would be better - it's explicit, it explains the order clearly.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should describe all possible source and their priorities at the very beginning

Agree. Done in 8b035c1. But this section has gotten really complicated. This needs it's own guide I think (great first candidate for #1859 which keeps coming up BTW, so hopefully we can prioritize it).

@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-azure-config-di-4w9snq August 18, 2021 03:00 Inactive
@jorgeorpinel jorgeorpinel self-assigned this Aug 18, 2021
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-azure-config-di-4w9snq August 18, 2021 03:17 Inactive
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-azure-config-di-4w9snq August 18, 2021 03:29 Inactive
@jorgeorpinel jorgeorpinel merged commit 3643e6d into master Aug 18, 2021
@casperdcl casperdcl deleted the azure-config-dir branch August 18, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants