Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure: mention that we search azure config #2703

Merged
merged 4 commits into from
Aug 18, 2021
Merged

azure: mention that we search azure config #2703

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6c635f1
azure: mention that we search azure config
isidentical Aug 10, 2021
4909f0b
Merge branch 'master' into azure-config-dir
jorgeorpinel Aug 18, 2021
c255e22
ref: specify which options and when are taken from Azure config
jorgeorpinel Aug 18, 2021
8b035c1
ref: explain Azure auth routes from the beginning of section
jorgeorpinel Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions content/docs/command-reference/remote/modify.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -481,6 +481,12 @@ $ export AZURE_PASSWORD='mysecret'
> [env vars](https://docs.microsoft.com/en-us/python/api/azure-identity/azure.identity.environmentcredential)
> available.

Also some options can be propagated from the azure config file (which is managed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: some options - what does it mean?

I think we should describe all possible source and their priorities at the very beginning of the section. No chances people will get to this last paragraph. And if I understand this correctly (this files serves the same role as AWS credentials), this seems to be an important information that we want and should mention from the very beginning.

Something like: there are a few ways to define config values, in the order of their priority:

  1. config files
  2. env
  3. DVC config

etc

(This is just an example, I don't know the details here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: some options - what does it mean?

#2703 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That comment if you put it somewhere at the top of the document would be better - it's explicit, it explains the order clearly.

Copy link
Contributor

@jorgeorpinel jorgeorpinel Aug 18, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should describe all possible source and their priorities at the very beginning

Agree. Done in 8b035c1. But this section has gotten really complicated. This needs it's own guide I think (great first candidate for #1859 which keeps coming up BTW, so hopefully we can prioritize it).

through
[az config](https://docs.microsoft.com/en-us/cli/azure/config?view=azure-cli-latest)).
The default directory where the config will be searched is `~/.azure` but it can
be customized through `AZURE_CONFIG_DIR` variable.

</details>

<details>
Expand Down