Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: tabs for Windows cmd blocks (Versioning page) #3273

Merged
merged 7 commits into from
Mar 1, 2022
Merged

Conversation

jorgeorpinel
Copy link
Contributor

@jorgeorpinel jorgeorpinel commented Feb 11, 2022

Rel. #2939

@shcheklein shcheklein temporarily deployed to dvc-org-powershell-i4xiqnltbpg February 11, 2022 16:14 Inactive
@jorgeorpinel jorgeorpinel marked this pull request as ready for review February 11, 2022 16:38
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-powershell-i4xiqnltbpg February 11, 2022 16:38 Inactive
@jorgeorpinel jorgeorpinel changed the title start: use powershell highligher for tab toggles start: use powershell highligher for tab toggles (Versioning page) Feb 11, 2022
@jorgeorpinel jorgeorpinel changed the title start: use powershell highligher for tab toggles (Versioning page) start: use powershell tabs (Versioning page) Feb 11, 2022
@jorgeorpinel jorgeorpinel self-assigned this Feb 11, 2022
Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not using powershell after all, as agreed in #3273 (review)

content/docs/start/data-and-model-versioning.md Outdated Show resolved Hide resolved
content/docs/start/data-and-model-versioning.md Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-powershell-i4xiqnltbpg February 12, 2022 18:01 Inactive
@jorgeorpinel jorgeorpinel changed the title start: use powershell tabs (Versioning page) start: tabs for Windows cmd blocks (Versioning page) Feb 12, 2022
Copy link
Member

@shcheklein shcheklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor suggestion, looks good to me otherwise

Copy link
Contributor Author

@jorgeorpinel jorgeorpinel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

content/docs/start/data-and-model-versioning.md Outdated Show resolved Hide resolved
content/docs/start/data-and-model-versioning.md Outdated Show resolved Hide resolved
@jorgeorpinel jorgeorpinel temporarily deployed to dvc-org-powershell-i4xiqnltbpg March 1, 2022 18:12 Inactive
@jorgeorpinel jorgeorpinel merged commit 0a631f9 into master Mar 1, 2022
@jorgeorpinel jorgeorpinel deleted the powershell branch March 1, 2022 18:13
iesahin pushed a commit that referenced this pull request Apr 11, 2022
* start: use `powershell` highligher for tab toggles
per #3215 (comment)

* start: Windows command tabs for Versioning page

* start: use `dvc` highlighter (and `$`) for Windows cmd blocks

per #3273 (review)

* start: Windows code blocks for /tmp location

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants