Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start: update command blocks with tabs for Windows #3311

Closed
1 of 5 tasks
Tracked by #2939
iesahin opened this issue Feb 22, 2022 · 4 comments
Closed
1 of 5 tasks
Tracked by #2939

start: update command blocks with tabs for Windows #3311

iesahin opened this issue Feb 22, 2022 · 4 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: start Content of /doc/start good first issue Good for newcomers p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@iesahin
Copy link
Contributor

iesahin commented Feb 22, 2022

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Feb 22, 2022

Idk, it kind of depends on the discussions going on in #3273 (about how deep we want to go into being Windows-friendly). WDYT @shcheklein ?

@jorgeorpinel jorgeorpinel changed the title start: Update command snippets with tabs for Unix & Windows start: Update command snippets with tabs for Unix & Windows Feb 22, 2022
@jorgeorpinel jorgeorpinel changed the title start: Update command snippets with tabs for Unix & Windows start: update command blocks with tabs for Windows Feb 22, 2022
@shcheklein
Copy link
Member

@jorgeorpinel I think tabs make the most sense for Windows. Not sure why we should be concerned about using them this way. Or may be I don't understand the context ... could you please clarify?

@jorgeorpinel
Copy link
Contributor

@shcheklein we weren't sure whether it was worth it to make Windows tabs just to change paths such as /tmp which don't work on Windows but we discussed this last retro and decided to DO create those tabs. However making tabs just to change / for \ we decided would be too much. For historical context see #3273 (review) or just review the PR 🙂

@jorgeorpinel jorgeorpinel added A: docs Area: user documentation (gatsby-theme-iterative) C: start Content of /doc/start type: enhancement Something is not clear, small updates, improvement suggestions labels Feb 28, 2022
@jorgeorpinel
Copy link
Contributor

From #3326 (comment)

Our statistics show we have very few Windows cmd users, anyone who's interested in DVC is using it on WSL probably. I think we can deprioritize this.

Fair point but it's probably still worth it for the Get Started, as we had decided earlier. Maybe it'll help onboard more Windows users this way.

@dberenbaum dberenbaum added p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. good first issue Good for newcomers labels Oct 16, 2023
@dberenbaum dberenbaum closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) C: start Content of /doc/start good first issue Good for newcomers p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

4 participants