Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prism: new or expanded DVC highlighter for Windows #3278

Closed
jorgeorpinel opened this issue Feb 12, 2022 · 4 comments
Closed

prism: new or expanded DVC highlighter for Windows #3278

jorgeorpinel opened this issue Feb 12, 2022 · 4 comments
Labels
A: website Area: website type: feature-request DEPRECATED New feature or request website: eng-doc DEPRECATED JS engine for /doc

Comments

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Feb 12, 2022

do a proper dvc highlighter that supports Windows (Command Prompt format, similar to Prism powershell)

Originally posted by @shcheklein in #3273 (comment)

@jorgeorpinel
Copy link
Contributor Author

jorgeorpinel commented Feb 12, 2022

Cc @iterative/websites

@jorgeorpinel jorgeorpinel added website: eng-doc DEPRECATED JS engine for /doc type: feature-request DEPRECATED New feature or request labels Feb 12, 2022
@jorgeorpinel jorgeorpinel changed the title prism: DVC highlighter for Windows prism: new or expanded DVC highlighter for Windows Feb 12, 2022
@julieg18 julieg18 added the A: website Area: website label Feb 14, 2022
@casperdcl
Copy link
Contributor

This is effectively just $ vs >, right?

@julieg18
Copy link
Contributor

his is effectively just $ vs >, right?

Possibly. Depends if we want to use powershell commands in some of our code blocks. Our dvc highlighter extends on bash and doesn't highlight windows commands properly. If we want to use powershell commands, then we'd need to create or extend our dvc highlighter to work with powershell, not just bash.
But if we just want to focus our code blocks on just using commands that work on both bash and powershell, we can probably just update our dvc highlighter to just check for $ or > in the beginning of a line.

@jorgeorpinel
Copy link
Contributor Author

update our dvc highlighter to just check for $ or > in the beginning of a line

It's a start.

@julieg18 julieg18 self-assigned this Feb 22, 2022
@julieg18 julieg18 removed their assignment Jul 11, 2022
@dberenbaum dberenbaum closed this as not planned Won't fix, can't repro, duplicate, stale Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website type: feature-request DEPRECATED New feature or request website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

No branches or pull requests

4 participants