Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide --rm-watermark option when invoking CML CLI #1235

Merged
merged 10 commits into from
Oct 26, 2022

Conversation

deepyaman
Copy link
Contributor

Close #1140

@deepyaman deepyaman temporarily deployed to external October 24, 2022 12:31 Inactive
@deepyaman deepyaman temporarily deployed to external October 24, 2022 12:31 Inactive
@deepyaman deepyaman marked this pull request as ready for review October 24, 2022 12:31
tasdomas
tasdomas previously approved these changes Oct 24, 2022
@deepyaman deepyaman temporarily deployed to external October 24, 2022 20:57 Inactive
@deepyaman deepyaman changed the title Hide --rm-watermark flag on cml comment create Hide --rm-watermark option when invoking CML CLI Oct 24, 2022
@casperdcl casperdcl added good-first-issue Good for newcomers (good-first-issue) cml-comment Subcommand p2-nice-to-have Low priority external-request You asked, we did labels Oct 25, 2022
@deepyaman deepyaman temporarily deployed to external October 25, 2022 00:06 Inactive
@deepyaman deepyaman temporarily deployed to external October 26, 2022 12:33 Inactive
@dacbd dacbd temporarily deployed to external October 26, 2022 20:44 Inactive
@dacbd dacbd enabled auto-merge (squash) October 26, 2022 20:47
@dacbd dacbd self-requested a review October 26, 2022 20:51
@dacbd dacbd merged commit b6c5bd6 into iterative:master Oct 26, 2022
@deepyaman deepyaman deleted the patch-1 branch October 26, 2022 22:21
tasdomas pushed a commit that referenced this pull request Oct 28, 2022
* Hide `--rm-watermark` flag on `cml comment create`

* Update create.test.js

* Update connect.js

* Update connect.test.js

* Update publish.js

* Update publish.test.js

* Update publish.test.js

* Update connect.test.js

Co-authored-by: Daniel Barnes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cml-comment Subcommand external-request You asked, we did good-first-issue Good for newcomers (good-first-issue) p2-nice-to-have Low priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide cml comment <verb> --rm-watermark option
4 participants