Skip to content

Commit

Permalink
Hide --rm-watermark option when invoking CML CLI (#1235)
Browse files Browse the repository at this point in the history
* Hide `--rm-watermark` flag on `cml comment create`

* Update create.test.js

* Update connect.js

* Update connect.test.js

* Update publish.js

* Update publish.test.js

* Update publish.test.js

* Update connect.test.js

Co-authored-by: Daniel Barnes <[email protected]>
  • Loading branch information
deepyaman and dacbd authored Oct 26, 2022
1 parent 150a0eb commit b6c5bd6
Show file tree
Hide file tree
Showing 6 changed files with 18 additions and 19 deletions.
1 change: 1 addition & 0 deletions bin/cml/asset/publish.js
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ exports.options = kebabcaseKeys({
rmWatermark: {
type: 'boolean',
description: 'Avoid CML watermark.',
hidden: true,
telemetryData: 'name'
},
mimeType: {
Expand Down
11 changes: 5 additions & 6 deletions bin/cml/asset/publish.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,11 @@ describe('CML cli test', () => {
--help Show help [boolean]
Options:
--md Output in markdown format [title || name](url) [boolean]
-t, --title Markdown title [title](url) or ![](url title) [string]
--native Uses driver's native capabilities to upload assets instead
of CML's storage; not available on GitHub [boolean]
--rm-watermark Avoid CML watermark. [boolean]
--mime-type MIME type [string] [default: infer from the file contents]"
--md Output in markdown format [title || name](url) [boolean]
-t, --title Markdown title [title](url) or ![](url title) [string]
--native Uses driver's native capabilities to upload assets instead of
CML's storage; not available on GitHub [boolean]
--mime-type MIME type [string] [default: infer from the file contents]"
`);
});
});
1 change: 1 addition & 0 deletions bin/cml/comment/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ exports.options = kebabcaseKeys({
type: 'boolean',
description:
'Avoid watermark; CML needs a watermark to be able to distinguish CML comments from others',
hidden: true,
telemetryData: 'name'
}
});
Expand Down
4 changes: 1 addition & 3 deletions bin/cml/comment/create.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ describe('Comment integration tests', () => {
[string] [default: \\"https://asset.cml.dev\\"]
--publish-native, --native Uses driver's native capabilities to upload assets
instead of CML's storage; not available on GitHub
[boolean]
--rm-watermark Avoid watermark; CML needs a watermark to be able
to distinguish CML comments from others [boolean]"
[boolean]"
`);
});
});
1 change: 1 addition & 0 deletions bin/cml/tensorboard/connect.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ exports.options = kebabcaseKeys({
rmWatermark: {
type: 'boolean',
description: 'Avoid CML watermark',
hidden: true,
telemetryData: 'name'
}
});
Expand Down
19 changes: 9 additions & 10 deletions bin/cml/tensorboard/connect.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,17 +20,16 @@ describe('CML e2e', () => {
--help Show help [boolean]
Options:
-c, --credentials TensorBoard credentials as JSON, usually found at
~/.config/tensorboard/credentials/uploader-creds.json
-c, --credentials TensorBoard credentials as JSON, usually found at
~/.config/tensorboard/credentials/uploader-creds.json
[string] [required]
--logdir Directory containing the logs to process [string]
--name Tensorboard experiment title; max 100 characters [string]
--description Tensorboard experiment description in Markdown format; max
600 characters [string]
--md Output as markdown [title || name](url) [boolean]
-t, --title Markdown title, if not specified, param name will be used
[string]
--rm-watermark Avoid CML watermark [boolean]"
--logdir Directory containing the logs to process [string]
--name Tensorboard experiment title; max 100 characters [string]
--description Tensorboard experiment description in Markdown format; max
600 characters [string]
--md Output as markdown [title || name](url) [boolean]
-t, --title Markdown title, if not specified, param name will be used
[string]"
`);
});
});

0 comments on commit b6c5bd6

Please sign in to comment.