Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide --rm-watermark option when invoking CML CLI #1235

Merged
merged 10 commits into from
Oct 26, 2022
Merged

Hide --rm-watermark option when invoking CML CLI #1235

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
34628c5
Hide `--rm-watermark` flag on `cml comment create`
deepyaman Oct 24, 2022
7558530
Update create.test.js
deepyaman Oct 24, 2022
918b025
Update connect.js
deepyaman Oct 24, 2022
06623b5
Update connect.test.js
deepyaman Oct 24, 2022
38e8eba
Update publish.js
deepyaman Oct 24, 2022
4811d93
Update publish.test.js
deepyaman Oct 24, 2022
6853f3c
Update publish.test.js
deepyaman Oct 25, 2022
1d49da1
Update connect.test.js
deepyaman Oct 25, 2022
655b9d6
Merge branch 'master' into patch-1
deepyaman Oct 26, 2022
4ecb45d
Merge branch 'master' into patch-1
dacbd Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/cml/comment/create.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ exports.options = kebabcaseKeys({
type: 'boolean',
description:
'Avoid watermark; CML needs a watermark to be able to distinguish CML comments from others',
hidden: true,
telemetryData: 'name'
}
});
Expand Down
4 changes: 1 addition & 3 deletions bin/cml/comment/create.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ describe('Comment integration tests', () => {
[string] [default: \\"https://asset.cml.dev\\"]
--publish-native, --native Uses driver's native capabilities to upload assets
instead of CML's storage; not available on GitHub
[boolean]
--rm-watermark Avoid watermark; CML needs a watermark to be able
to distinguish CML comments from others [boolean]"
[boolean]"
`);
});
});