Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify duplicate telemetry sending logic #1124

Closed
wants to merge 40 commits into from
Closed

Simplify duplicate telemetry sending logic #1124

wants to merge 40 commits into from

Conversation

0x2b3bfa0
Copy link
Member

@0x2b3bfa0 0x2b3bfa0 commented Aug 9, 2022 •
edited
Loading

To be merged into #1092 if deemed opportune, based on #1092 (comment)

  • Remove duplicate telemetry calls for every single command
  • Avoid using a globally scoped variable to store command-line options

DavidGOrtega and others added 30 commits July 9, 2022 18:07
@DavidGOrtega
Telemetry
f6ed7bf
@DavidGOrtega
appdirs
d97b0c1
@DavidGOrtega
analytics tested
ec6b5e3
@DavidGOrtega
remove analytics
4e9ac5d
@DavidGOrtega
deterministic check
e569c3b
@DavidGOrtega
remove fake code
f53673e
@DavidGOrtega
fix isCI
e74eda2
@DavidGOrtega
cml
e71fec8
@DavidGOrtega
integrated
271fd5c
@DavidGOrtega
endpoint
052f68d
@DavidGOrtega
defensive
cef1830
@DavidGOrtega
json spec
0b8790c
@0x2b3bfa0
Telemetry (#1092) suggestion: don't repeat ourselves (#1094)
e5d0657 
* Telemetry (#1092) suggestion: don't repeat ourselves

* Fix manual merging mistakes

* Obliterate the last process.exit on business logic
@DavidGOrtega
dryer cml
d818b82
@DavidGOrtega
dryer cml
9e1a351
@DavidGOrtega
telemetrySend
554d909
@DavidGOrtega
naming consistency
41ec815
@DavidGOrtega
read non json id
53f800b
@DavidGOrtega
gh check repoOptions
977ddd5
@DavidGOrtega
one error handler
dd9dfd5
@DavidGOrtega
Merge branch 'master' of https://github.com/iterative/cml into telemetry
32edb2d
@DavidGOrtega
fix tensorboard
181ab44
@DavidGOrtega
fix tensorboard and tests
34152a7
@DavidGOrtega
cleanup yargs fail handler
e7b9d9b
@DavidGOrtega
unused
1b2a618
@DavidGOrtega
RUNNER_SHUTTING_DOWN
1a79b29
@DavidGOrtega
remove comments
ef13e13
@DavidGOrtega
golantic
6f1f931
@DavidGOrtega
Merge branch 'master' of https://github.com/iterative/cml into telemetry
2589efa
@DavidGOrtega
getDriver
006e226
@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal August 9, 2022 10:56 Inactive
@0x2b3bfa0 0x2b3bfa0 self-assigned this Aug 9, 2022
@0x2b3bfa0 0x2b3bfa0 requested a review from a team August 9, 2022 10:56
@0x2b3bfa0 0x2b3bfa0 added the technical-debt Refactoring, linting & tidying label Aug 9, 2022
@0x2b3bfa0 0x2b3bfa0 mentioned this pull request Aug 9, 2022
Merged
DavidGOrtega
DavidGOrtega suggested changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@DavidGOrtega DavidGOrtega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now this PR is broken.
Try

./bin/cml.js runner --labels cml --single --repo yourrepo

@0x2b3bfa0 0x2b3bfa0 temporarily deployed to internal August 9, 2022 12:11 Inactive
@0x2b3bfa0 0x2b3bfa0 requested a review from DavidGOrtega August 9, 2022 12:12
Base automatically changed from telemetry to master August 10, 2022 16:53
@DavidGOrtega
Copy link
Contributor

I have the plan to review this and approve it today @0x2b3bfa0

This was referenced Aug 15, 2022
Closed
Closed
@DavidGOrtega DavidGOrtega mentioned this pull request Aug 16, 2022
Merged
@0x2b3bfa0 0x2b3bfa0 deleted the telemetry-suggestions branch October 14, 2022 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidGOrtega DavidGOrtega Awaiting requested review from DavidGOrtega

Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0x2b3bfa0 @DavidGOrtega