Telemetry (#1092) suggestion: don't repeat ourselves #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0x2b3bfa0
added
enhancement
Merged
DavidGOrtega
added a commit
that referenced
this pull request
Aug 10, 2022
* Telemetry * appdirs * analytics tested * remove analytics * deterministic check * remove fake code * fix isCI * cml * integrated * endpoint * defensive * json spec * Telemetry (#1092) suggestion: don't repeat ourselves (#1094) * Telemetry (#1092) suggestion: don't repeat ourselves * Fix manual merging mistakes * Obliterate the last process.exit on business logic * dryer cml * telemetrySend * naming consistency * read non json id * gh check repoOptions * one error handler * fix tensorboard * fix tensorboard and tests * cleanup yargs fail handler * unused * RUNNER_SHUTTING_DOWN * remove comments * golantic * getDriver * fix telemetry * fix getter * remove report * remove console * fix os release * windows release Co-authored-by: Helio Machado <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplementary code example accompanying #1092 (review), would probably close #1093. May contain traces of incompatible behavior, expecially with regard to
process.exitandtensorboardprocess magic.