Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CML entrypoint improvements #1093

Closed
DavidGOrtega opened this issue Jul 12, 2022 · 0 comments · Fixed by #1094 or #1092
Closed

CML entrypoint improvements #1093

DavidGOrtega opened this issue Jul 12, 2022 · 0 comments · Fixed by #1094 or #1092
Labels
technical-debt Refactoring, linting & tidying

Comments

@DavidGOrtega
Copy link
Contributor

With #1092 we had to spread the telemetry send command in every CML command. Ideally we should just only have to do it in bin/cml.js

issues

  • We should have only one generic entrypoint in bin/cml.js that sets CM, kebabrize parameters, etc...
  • We should never, ever do process.exit outside bin/cml.js
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
1 participant
@DavidGOrtega