-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix telemetry unsupported async #1131
Conversation
Not tested (away from keyboard) but looks good. Have you considered |
Which one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
yargs fail do not support
await
if used the app throws a strange uncontrolled ecmascript exception. Due to thisunhandledexception
andunhandledrejection
events were triggered raising analytics three times that would not even execute doe the the ecmascript exception.yargs seems also the throw the error after the fail function, something that it does not do it with the default handler.
This PR follow the amazing work that @0x2b3bfa0 did at #1124 to simplify the telemetry however the approach due to the mentioned error is a bit different