Fix CircleCI build and Golang linting #186

frankmariette · 2021-11-18T21:18:30Z

CI builds are failing due to the certificate change shown here. Updating to the latest image from Circle CI fixes this problem and allows Admiral to build again as expected.

Fixed linter to run though did not make changes to any current files to limit this to just fixing CI and not lint issues.

nirvanagit · 2021-11-18T22:57:33Z

.circleci/config.yml

@@ -7,7 +7,7 @@ jobs:
  build:
    working_directory: /go/pkg/mod/github.com/admiral
    docker:
-    - image: circleci/golang:1.11
+    - image: circleci/golang:1.16


Should we use 1.17 ?

nirvanagit · 2021-11-18T22:58:00Z

.circleci/config.yml

@@ -54,6 +54,7 @@ jobs:
      MINIKUBE_WANTREPORTERRORPROMPT: false
      MINIKUBE_HOME: /home/circleci
      CHANGE_MINIKUBE_NONE_USER: true
+    resource_class: large


Curious to know why we need a large build container (assuming it is a build container)

This is for the integration tests. The container was increased to match the size that CircleCI has with the limits I increased minikube to. https://circleci.com/docs/2.0/configuration-reference/#resourceclass

nirvanagit · 2021-11-18T22:58:43Z

tests/create_cluster.sh

@@ -5,7 +5,7 @@
 k8s_version=$1

 if [[ $IS_LOCAL == "false" ]]; then
-  sudo -E minikube start --vm-driver=none --cpus 4 --memory 4096 --kubernetes-version=$k8s_version &> $HOME/minikube.log 2>&1 < /dev/null
+  sudo -E minikube start --vm-driver=none --cpus 6 --memory 6144 --kubernetes-version=$k8s_version &> $HOME/minikube.log 2>&1 < /dev/null


Is the increment in resources due to some new dependency?

Increased demands for the tests with added GRPC clients. I noticed the tests were flaky and seemed to be failing to timeout. Experience with running minikube has shown that the lack of responsiveness occurs when it becomes resource strapped so I increased it to account for this. I also had to increase the integration test vm resources to account for this change as well.

Signed-off-by: Francois Mariette <[email protected]>

Signed-off-by: psikka1 <[email protected]>

* Temporary jenkins file to deploy only in qal * Only Build in new jenkins - testing * boilerplate code for traffic config crd * envoy filter creation code * WIP - refactored to separate Traffic Controller and Remote controllers * adding code for decoupled logic * removed commented code, added functionality for remote worker manager * changing workerMgrMap from normal map to sync.Map to handle concurrent access * test checkin * Bootstrap changes * add dependency, rollout & service controllers * add dependency, rollout & service controllers * service entry not needed for admiral-unification * implemented decideEnvoyFilter logic * passing stopCh to processItem to propogate os.exit signal * added new function to get allkeys of a cache map and improved envoy filter creation * Branch name correction in jenkins * Branch name correction in jenkins (#183) * change to us west2 * Ratelimiting filter logic (#184) * Branch name correction in jenkins * change to us west2 * Change default traffic config namespace * Ratelimiting filter logic (#185) * Branch name correction in jenkins * change to us west2 * Change default traffic config namespace * do not proceed with vs geberation in case of rollout * Ratelimiting filter logic (#186) * Branch name correction in jenkins * change to us west2 * Change default traffic config namespace * do not proceed with vs geberation in case of rollout * adding debug statements to identify GetKey() cache panic * reverting back the envoyfilter namespace to admiral-sync * Handle remote cluster unavailability (#191) * Ratelimiting filter logic (#192) * Handle remote cluster unavailability * remove unwanted space before api version * adding new fields to traffic config crd * completed envoy filter operations * updated error handling for processItem function * fixing crd not registered issue * added workload labels i.e. deployment/rollout labels to envoyfilter * updating traffic config CRD to add timeout for edgeservice spec and handling nil cache panic * Ignore updates in passive mode (#197) * Merge heliograph changes (#198) * Ignore updates in passive mode * merge heliograph changes(temporary) * Ratelimiting filter logic (#199) * Ignore updates in passive mode * merge heliograph changes(temporary) * Update heliograph from admiral-deployment, not from jenkins * Temporary hack to override heliograph tag (#200) * Ignore updates in passive mode * merge heliograph changes(temporary) * Update heliograph from admiral-deployment, not from jenkins * temporary hack to override heliograph tag * undo heliograph changes in jenkins * undo heliograph changes in jenkins (#201) * undo heliograph changes in jenkins (#201) * change envoy filter namespace & move vs creation to a different file * change envoy filter namespace & move vs creation to a different file (#203) * undo heliograph changes in jenkins * change envoy filter namespace & move vs creation to a different file * fixing context * vs deletion * logging improvement, deletion (#205) * undo heliograph changes in jenkins * change envoy filter namespace & move vs creation to a different file * vs deletion * asseralias to be in lowercase * debugging labels issue (#207) * no need of retries in vs * Deploy label debugging (#209) * debugging labels issue * handling map update * adding code changes to correct envoy filters and logging struct (#210) * Envofilter formatting (#211) * adding code changes to correct envoy filters and logging struct * updating service now image * Envofilter formatting (#212) * adding code changes to correct envoy filters and logging struct * updating service now image * envoyfilter namespace changed from admiral-sync to istio-system * changing envoy filter namespace from admiral-sync to istio-system (#213) * Ns change (#214) * changing envoy filter namespace from admiral-sync to istio-system * fixing envoyfilter issue for name and struct * vs env delete fix * handling traffic config isDisbaled annotation, also handling update and delete (#217) * cname identity map pupulation fix * position gervice entry selector only for admiral * altering traffic config persona code flow in service entry * altering traffic config persona code flow in service entry (#221) * making strings as const in common for resue * Unification test (#222) * altering traffic config persona code flow in service entry * making strings as const in common for resue * adding adaptive concurrency filter * altering traffic config persona code flow in service entry * remove cluster from map upon deletion * debug traces * review comments * null check for virtual service * worker manager pointer corrected * add traffic config object for all clusters the asset is in * envoy filter env crud fix * admiral-unification in qal east * handling empty workloadenvselector lable case (#228) * Delete registry.go_backup Not needed * Delete types.go_backup * Delete virtualservice.go_backup * Delete envoyfilter-operations.go_backup * merge conflict for pull req 229 Co-authored-by: Rajendra Gosavi <[email protected]>

frankmariette changed the title ~~update circleci configuration and linter to use latest versions~~ Fix CircleCI build and Golang linting Nov 18, 2021

frankmariette force-pushed the ci-fixes branch 3 times, most recently from c84c256 to 89cd7ef Compare November 18, 2021 22:51

nirvanagit reviewed Nov 18, 2021

View reviewed changes

frankmariette force-pushed the ci-fixes branch from 7236ada to d6d3281 Compare December 3, 2021 22:54

Francois Mariette added 7 commits December 3, 2021 15:37

update circleci configuration and linter to use latest versions

ba40823

Signed-off-by: Francois Mariette <[email protected]>

remove out-format as reported by linter

bad7ad5

Signed-off-by: Francois Mariette <[email protected]>

provide more resources for minikube

9597105

Signed-off-by: Francois Mariette <[email protected]>

provide more resources for minikube

65d03b7

Signed-off-by: Francois Mariette <[email protected]>

fix linting

8646eb1

Signed-off-by: Francois Mariette <[email protected]>

add parrellelism to admiral build circle ci

4555af2

Signed-off-by: Francois Mariette <[email protected]>

fix linting

80ea845

Signed-off-by: Francois Mariette <[email protected]>

frankmariette force-pushed the ci-fixes branch from d6d3281 to 80ea845 Compare December 3, 2021 23:37

aattuluri approved these changes Dec 3, 2021

View reviewed changes

aattuluri merged commit 4259ea7 into master Dec 3, 2021

aattuluri deleted the ci-fixes branch December 3, 2021 23:58

psikka1 pushed a commit to psikka1/admiral that referenced this pull request Jun 15, 2022

Fix CircleCI build and Golang linting (istio-ecosystem#186)

c5ab72a

Signed-off-by: psikka1 <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix CircleCI build and Golang linting #186

Fix CircleCI build and Golang linting #186

frankmariette commented Nov 18, 2021 •

edited

Loading

nirvanagit Nov 18, 2021

nirvanagit Nov 18, 2021

frankmariette Nov 18, 2021

nirvanagit Nov 18, 2021

frankmariette Nov 18, 2021

Fix CircleCI build and Golang linting #186

Fix CircleCI build and Golang linting #186

Conversation

frankmariette commented Nov 18, 2021 • edited Loading

nirvanagit Nov 18, 2021

Choose a reason for hiding this comment

nirvanagit Nov 18, 2021

Choose a reason for hiding this comment

frankmariette Nov 18, 2021

Choose a reason for hiding this comment

nirvanagit Nov 18, 2021

Choose a reason for hiding this comment

frankmariette Nov 18, 2021

Choose a reason for hiding this comment

frankmariette commented Nov 18, 2021 •

edited

Loading