Support for BlueGreen rollout preview endpoint #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 16, 2022 18:33
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
asushanthk
reviewed
Mar 18, 2022
added 2 commits
March 18, 2022 17:45
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
added 2 commits
March 25, 2022 09:01
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
aattuluri
requested changes
Mar 29, 2022
Signed-off-by: nbn01 <[email protected]>
itsLucario
force-pushed
the
bluegreen-preview-endpoint-rollout
branch
from
c36fb50 to
50c0ce5
Compare
added 2 commits
March 31, 2022 20:02
Signed-off-by: nbn01 <[email protected]>
Signed-off-by: nbn01 <[email protected]>
itsLucario
force-pushed
the
bluegreen-preview-endpoint-rollout
branch
from
5a2e8b7 to
c97ed13
Compare
Codecov Report
@@ Coverage Diff @@
## master #199 +/- ##
==========================================
+ Coverage 74.42% 75.02% +0.60%
==========================================
Files 26 26
Lines 2530 2567 +37
==========================================
+ Hits 1883 1926 +43
+ Misses 516 512 -4
+ Partials 131 129 -2
Continue to review full report at Codecov.
|
aattuluri
requested changes
Apr 4, 2022
|
@itsLucario There are lint errors, fix them before we can merge. |
itsLucario
force-pushed
the
bluegreen-preview-endpoint-rollout
branch
2 times, most recently
from
bac0a2b to
c97ed13
Compare
Signed-off-by: nbn01 <[email protected]>
golangci-lint was using go1.18 that caused the panic. I added a fix to the workflow to use go1.17.7. |
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 14, 2022
…m#199) * Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Updated integration test for preview endpoint Signed-off-by: nbn01 <[email protected]> * Minor check fixes Signed-off-by: nbn01 <[email protected]> * Reverted integration test changes Signed-off-by: nbn01 <[email protected]> * Update unit tests Signed-off-by: nbn01 <[email protected]> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Update makefile Signed-off-by: nbn01 <[email protected]> * Modified permissions Signed-off-by: nbn01 <[email protected]> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <[email protected]> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <[email protected]> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <[email protected]> * Uncomment clean up Signed-off-by: nbn01 <[email protected]> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <[email protected]> * abstract update preview endpoint to method Signed-off-by: nbn01 <[email protected]> * Add unit test Signed-off-by: nbn01 <[email protected]> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <[email protected]> Co-authored-by: nbn01 <[email protected]>
psikka1
pushed a commit
to psikka1/admiral
that referenced
this pull request
Jun 15, 2022
…m#199) * Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Updated integration test for preview endpoint Signed-off-by: nbn01 <[email protected]> * Minor check fixes Signed-off-by: nbn01 <[email protected]> * Reverted integration test changes Signed-off-by: nbn01 <[email protected]> * Update unit tests Signed-off-by: nbn01 <[email protected]> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Update makefile Signed-off-by: nbn01 <[email protected]> * Modified permissions Signed-off-by: nbn01 <[email protected]> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <[email protected]> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <[email protected]> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <[email protected]> * Uncomment clean up Signed-off-by: nbn01 <[email protected]> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <[email protected]> * abstract update preview endpoint to method Signed-off-by: nbn01 <[email protected]> * Add unit test Signed-off-by: nbn01 <[email protected]> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <[email protected]> Co-authored-by: nbn01 <[email protected]> Signed-off-by: psikka1 <[email protected]>
asushanthk
pushed a commit
that referenced
this pull request
Jul 21, 2022
* Changes to support preview endpoint for bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Updated integration test for preview endpoint Signed-off-by: nbn01 <[email protected]> * Minor check fixes Signed-off-by: nbn01 <[email protected]> * Reverted integration test changes Signed-off-by: nbn01 <[email protected]> * Update unit tests Signed-off-by: nbn01 <[email protected]> * Add integration test for preview endpoint of bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Update makefile Signed-off-by: nbn01 <[email protected]> * Modified permissions Signed-off-by: nbn01 <[email protected]> * Reverting argo_rollouts default to false Signed-off-by: nbn01 <[email protected]> * Updated unit tests to check when preview service not defined Signed-off-by: nbn01 <[email protected]> * Improved integration test for bluegreen rollout Signed-off-by: nbn01 <[email protected]> * Continue with normal flow if preview condition fails Signed-off-by: nbn01 <[email protected]> * Uncomment clean up Signed-off-by: nbn01 <[email protected]> * make "preview" standard prefix name for bluegreen Signed-off-by: nbn01 <[email protected]> * abstract update preview endpoint to method Signed-off-by: nbn01 <[email protected]> * Add unit test Signed-off-by: nbn01 <[email protected]> * fix golintci lint to use go1.17.7 Signed-off-by: nbn01 <[email protected]> Co-authored-by: nbn01 <[email protected]> Signed-off-by: sa <[email protected]>
kpharasi
pushed a commit
that referenced
this pull request
Dec 19, 2024
* Temporary jenkins file to deploy only in qal * Only Build in new jenkins - testing * boilerplate code for traffic config crd * envoy filter creation code * WIP - refactored to separate Traffic Controller and Remote controllers * adding code for decoupled logic * removed commented code, added functionality for remote worker manager * changing workerMgrMap from normal map to sync.Map to handle concurrent access * test checkin * Bootstrap changes * add dependency, rollout & service controllers * add dependency, rollout & service controllers * service entry not needed for admiral-unification * implemented decideEnvoyFilter logic * passing stopCh to processItem to propogate os.exit signal * added new function to get allkeys of a cache map and improved envoy filter creation * Branch name correction in jenkins * Branch name correction in jenkins (#183) * change to us west2 * Ratelimiting filter logic (#184) * Branch name correction in jenkins * change to us west2 * Change default traffic config namespace * Ratelimiting filter logic (#185) * Branch name correction in jenkins * change to us west2 * Change default traffic config namespace * do not proceed with vs geberation in case of rollout * Ratelimiting filter logic (#186) * Branch name correction in jenkins * change to us west2 * Change default traffic config namespace * do not proceed with vs geberation in case of rollout * adding debug statements to identify GetKey() cache panic * reverting back the envoyfilter namespace to admiral-sync * Handle remote cluster unavailability (#191) * Ratelimiting filter logic (#192) * Handle remote cluster unavailability * remove unwanted space before api version * adding new fields to traffic config crd * completed envoy filter operations * updated error handling for processItem function * fixing crd not registered issue * added workload labels i.e. deployment/rollout labels to envoyfilter * updating traffic config CRD to add timeout for edgeservice spec and handling nil cache panic * Ignore updates in passive mode (#197) * Merge heliograph changes (#198) * Ignore updates in passive mode * merge heliograph changes(temporary) * Ratelimiting filter logic (#199) * Ignore updates in passive mode * merge heliograph changes(temporary) * Update heliograph from admiral-deployment, not from jenkins * Temporary hack to override heliograph tag (#200) * Ignore updates in passive mode * merge heliograph changes(temporary) * Update heliograph from admiral-deployment, not from jenkins * temporary hack to override heliograph tag * undo heliograph changes in jenkins * undo heliograph changes in jenkins (#201) * undo heliograph changes in jenkins (#201) * change envoy filter namespace & move vs creation to a different file * change envoy filter namespace & move vs creation to a different file (#203) * undo heliograph changes in jenkins * change envoy filter namespace & move vs creation to a different file * fixing context * vs deletion * logging improvement, deletion (#205) * undo heliograph changes in jenkins * change envoy filter namespace & move vs creation to a different file * vs deletion * asseralias to be in lowercase * debugging labels issue (#207) * no need of retries in vs * Deploy label debugging (#209) * debugging labels issue * handling map update * adding code changes to correct envoy filters and logging struct (#210) * Envofilter formatting (#211) * adding code changes to correct envoy filters and logging struct * updating service now image * Envofilter formatting (#212) * adding code changes to correct envoy filters and logging struct * updating service now image * envoyfilter namespace changed from admiral-sync to istio-system * changing envoy filter namespace from admiral-sync to istio-system (#213) * Ns change (#214) * changing envoy filter namespace from admiral-sync to istio-system * fixing envoyfilter issue for name and struct * vs env delete fix * handling traffic config isDisbaled annotation, also handling update and delete (#217) * cname identity map pupulation fix * position gervice entry selector only for admiral * altering traffic config persona code flow in service entry * altering traffic config persona code flow in service entry (#221) * making strings as const in common for resue * Unification test (#222) * altering traffic config persona code flow in service entry * making strings as const in common for resue * adding adaptive concurrency filter * altering traffic config persona code flow in service entry * remove cluster from map upon deletion * debug traces * review comments * null check for virtual service * worker manager pointer corrected * add traffic config object for all clusters the asset is in * envoy filter env crud fix * admiral-unification in qal east * handling empty workloadenvselector lable case (#228) * Delete registry.go_backup Not needed * Delete types.go_backup * Delete virtualservice.go_backup * Delete envoyfilter-operations.go_backup * merge conflict for pull req 229 Co-authored-by: Rajendra Gosavi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when Admiral generates endpoint for Rollouts with bluegreen it always uses active/stable service as destination. This PR will adds a feature to generate an additional mesh endpoint that would point to the preview service of the blugreen stack.