fix linting

istio-ecosystem · Dec 3, 2021 · 7236ada · 7236ada
1 parent 73c664f
commit 7236ada
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/admiral/pkg/apis/admiral/routes/handlers.go b/admiral/pkg/apis/admiral/routes/handlers.go
@@ -103,7 +103,10 @@ func (opts *RouteOpts) GetServiceEntriesByCluster(w http.ResponseWriter, r *http
 				} else {
 					w.Header().Set("Content-Type", "application/json")
 					w.WriteHeader(200)
-					w.Write(out)
+					_, err := w.Write(out)
+					if err != nil {
+						log.Println("failed to write resp body: ", err)
+					}
 				}
 			}
 		}
@@ -140,7 +143,10 @@ func (opts *RouteOpts) GetServiceEntriesByIdentity(w http.ResponseWriter, r *htt
 		} else {
 			w.Header().Set("Content-Type", "application/json")
 			w.WriteHeader(200)
-			w.Write(out)
+			_, err := w.Write(out)
+			if err != nil {
+				log.Println("failed to write resp body", err)
+			}
 		}
 	} else {
 		log.Printf("Identity not provided as part of the request")

diff --git a/admiral/pkg/apis/admiral/server/server.go b/admiral/pkg/apis/admiral/server/server.go
@@ -98,7 +98,6 @@ func waitForStop(s *Service) {
 		if err != nil {
 			log.Println("error stopping server: ", err)
 		}
-		return
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -98,7 +98,6 @@ func waitForStop(s *Service) { @@
     		if err != nil {
     			log.Println("error stopping server: ", err)
     		}
-    		return
     	}
     }
@@ Expand Down @@