Feat/get all collections directories #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+38
to
+42
| if ( | ||
| curr.type === 'dir' | ||
| && !ISOMER_TEMPLATE_DIRS.includes(curr.name) | ||
| && curr.name.slice(0, 1) === '_' | ||
| ) acc.push(curr.path) |
There was a problem hiding this comment.
We could remove the underscore on the backend instead of the frontend, but I'm open to either option
There was a problem hiding this comment.
Resolved with 7f8b635. For consistency, we will abstract the _ character away from the frontend entirely, and the backend will be responsible for removing and appending the _ character
Merged
|
lgtm. Regarding underscore prefix, based on offline discussion we have decided that frontend will have no knowledge of underscore prefix, hence backend will handle any necessary prefixing and slicing. |
gweiying
approved these changes
Mar 3, 2021
This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo.
This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection
kwajiehao
force-pushed
the
feat/get-all-collections-directories
branch
from
7f8b635 to
b78ca35
Compare
Merged
kwajiehao
added a commit
that referenced
this pull request
Mar 3, 2021
* feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name * fix: use read route handler wrapper Co-authored-by: jiehao <[email protected]>
gweiying
added a commit
that referenced
this pull request
Mar 3, 2021
gweiying
added a commit
that referenced
this pull request
Mar 4, 2021
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * feat: create CollectionConfig which extends Config class, with methods for creating and deleting the collection.yml file * feat: updates Collection class to use CollectionConfig for create, delete and rename functions * fix: updates folders listAll route to use CollectionConfig * fix: adds more details to inline comment for .list() * feat: adds functions to support adding and removing item from CollectionConfig * fix: removes endpoint variable * fix: uses passed siteName variable instead of class variable * fix: destructures err response status * fix: allows Collection.create to take in optional orderArray * fix: rename config to collectionConfig in Collection for clarity * fix: updates Collection.rename to modify collectionName in collection.yml after git tree changes * fix: typo in variable names Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
gweiying
added a commit
that referenced
this pull request
Mar 10, 2021
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * feat: add function for creating new collection page * feat: add route for creating new collection page * fix: updates createCollectionPage endpoint to use /new in endpoint url * feat: creates equivalent createPage endpoint for creating new unlinked pages * fix: updates authenticated endpoints on backend * fix: updates unlinkedPages to use Directory for .list() * fix: removes unused listUnlinkedPages route Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
gweiying
added a commit
that referenced
this pull request
Mar 17, 2021
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * fix: resolving merge conflicts * fix: restores comments that were accidentally deleted * fix: applies missing URI decoding to page routes * fix: updates CollectionConfig to return and accept spliced index * fix: updates renameCollectionPage to use updated CollectionConfig functions * fix: adds updateItemInOrder and read methods to CollectionConfig * fix: updates collectionPages route to use updated CollectionConfig methods * fix: changes updateItemInOrder to use single read and update API call * fix: removes unused imports Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
gweiying
added a commit
that referenced
this pull request
Mar 31, 2021
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * feat: add moveResources API * fix: adds backend check for if resource categories exist prior to move * fix: update resourcePages routes to handle Base64 encoding on backend * fix: update moveResource route to work on single file only * Revert "fix: update moveResource route to work on single file only" This reverts commit 81b4786. * fix: typo in auth for resources route Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name * fix: use read route handler wrapper Co-authored-by: jiehao <[email protected]>
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * feat: create CollectionConfig which extends Config class, with methods for creating and deleting the collection.yml file * feat: updates Collection class to use CollectionConfig for create, delete and rename functions * fix: updates folders listAll route to use CollectionConfig * fix: adds more details to inline comment for .list() * feat: adds functions to support adding and removing item from CollectionConfig * fix: removes endpoint variable * fix: uses passed siteName variable instead of class variable * fix: destructures err response status * fix: allows Collection.create to take in optional orderArray * fix: rename config to collectionConfig in Collection for clarity * fix: updates Collection.rename to modify collectionName in collection.yml after git tree changes * fix: typo in variable names Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * feat: add function for creating new collection page * feat: add route for creating new collection page * fix: updates createCollectionPage endpoint to use /new in endpoint url * feat: creates equivalent createPage endpoint for creating new unlinked pages * fix: updates authenticated endpoints on backend * fix: updates unlinkedPages to use Directory for .list() * fix: removes unused listUnlinkedPages route Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * fix: resolving merge conflicts * fix: restores comments that were accidentally deleted * fix: applies missing URI decoding to page routes * fix: updates CollectionConfig to return and accept spliced index * fix: updates renameCollectionPage to use updated CollectionConfig functions * fix: adds updateItemInOrder and read methods to CollectionConfig * fix: updates collectionPages route to use updated CollectionConfig methods * fix: changes updateItemInOrder to use single read and update API call * fix: removes unused imports Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * feat: add moveResources API * fix: adds backend check for if resource categories exist prior to move * fix: update resourcePages routes to handle Base64 encoding on backend * fix: update moveResource route to work on single file only * Revert "fix: update moveResource route to work on single file only" This reverts commit 81b4786. * fix: typo in auth for resources route Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Note: this PR is to be reviewed in conjunction with PR #362 on the frontend.
It adds a new GET
/:siteName/folders/allendpoint which returns thecollection.ymldirectory config file for all collections/folders in the requested repo.