Feat/move resources #139
Merged
Feat/move resources #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]>
|
As discussed offline, since there are no use cases for bulk movement of resource pages between resource categories, we will be modifying this feature to move only single resource pages from one category to another |
This reverts commit 81b4786.
kwajiehao
suggested changes
Mar 25, 2021
middleware/auth.js
Outdated
| @@ -125,6 +126,7 @@ auth.get('/v1/sites/:siteName/resources', verifyJwt) | |||
| auth.post('/v1/sites/:siteName/resources', verifyJwt) | |||
| auth.delete('/v1/sites/:siteName/resources/:resourceName', verifyJwt) | |||
| auth.post('/v1/sites/:siteName/resources/:resourceName/rename/:newResourceName', verifyJwt) | |||
| auth.post('/v1/sites/:siteName/resources/:resourceRoomName/move/:newResourceRoomName', verifyJwt) | |||
There was a problem hiding this comment.
The route params specified here don't match the ones specified in the resources route file - resourceRoomName vs resourceName
There was a problem hiding this comment.
good catch, fixed here fd3410c
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * feat: add moveResources API * fix: adds backend check for if resource categories exist prior to move * fix: update resourcePages routes to handle Base64 encoding on backend * fix: update moveResource route to work on single file only * Revert "fix: update moveResource route to work on single file only" This reverts commit 81b4786. * fix: typo in auth for resources route Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an endpoint for moving resources from one resource room to another. Similar to the move endpoints for collection pages and pages, it takes in an array of files and iteratively deletes and creates new files.
This PR also adds simple refactoring to the resourcePages routes to handle Base64 encoding and decoding on the backend, extending #138.