Feat/update pageroutes #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]>
gweiying
changed the base branch from
Feat-read-from-nested-files-and-update-page-endpoints-for-nested-files
to
staging
gweiying
force-pushed
the
feat/update-pageroutes
branch
from
02f1a80 to
e1c378d
Compare
gweiying
requested review from
alexanderleegs and
kwajiehao
and removed request for
alexanderleegs
7 tasks
kwajiehao
reviewed
Mar 17, 2021
| return { index, item } | ||
| } | ||
|
|
||
| async updateItemInOrder(oldItem, newItem) { |
There was a problem hiding this comment.
It's nice to compose the updateItemInOrder from the other methods, but this results in two four API calls for what is essentially one update. Have we considered writing specific "update" code so only one two API calls are made?
There was a problem hiding this comment.
@gweiying brought up the possibility of building out the methods for the CollectionConfig class but as that would be a more significant undertaking we will be postponing that for now. As discussed, we will modify the updateItemInOrder method so that the the directory config file is read only once, and custom updating logic is applied instead of composing it with the addItem and deleteItem methods
| @@ -63,24 +63,6 @@ async function listPages (req, res, next) { | |||
| res.status(200).json({ pages }) | |||
| } | |||
|
|
|||
| // Create new page | |||
There was a problem hiding this comment.
Nit: could we also remove unused imports for this file?
alexanderleegs
approved these changes
Mar 17, 2021
This was referenced Mar 18, 2021
This was referenced Apr 13, 2021
Merged
harishv7
pushed a commit
that referenced
this pull request
Feb 17, 2023
* Feat/get all collections directories (#117) * feat: add RootType Directory This commit adds a RootType to the Directory class so that we can retrieve directories from the root of a repo. * feat: new endpoint for retrieving information on all folders This commit introduces a new GET `/:siteName/folders/all` endpoint which: 1) gets the names of all collections/folders within the repo 2) gets the collection.yml directory config file for each collection * fix: remove _ before sending folder name Co-authored-by: jiehao <[email protected]> * fix: resolving merge conflicts * fix: restores comments that were accidentally deleted * fix: applies missing URI decoding to page routes * fix: updates CollectionConfig to return and accept spliced index * fix: updates renameCollectionPage to use updated CollectionConfig functions * fix: adds updateItemInOrder and read methods to CollectionConfig * fix: updates collectionPages route to use updated CollectionConfig methods * fix: changes updateItemInOrder to use single read and update API call * fix: removes unused imports Co-authored-by: kwajiehao <[email protected]> Co-authored-by: jiehao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
pagesandcollectionPagesread,update,deleteandrenameroutes so that all path names are received and parsed as encodedURIComponents, and Base64 encoding happens only on the backend. This PR extends the changes introduced by Alex in #131.For
collectionPagesdeleteandrename, the collection config is also updated accordingly to remove/ rename the modified pages.This PR also updates the
CollectionConfig'saddItemToOrder,deleteItemFromOrder,updateItemInOrderandreadmethods to make the class more reusable.