-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update typescript, esbuild, tempy #1007
Conversation
Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
An error is logged saying TypeScript <= 4.5.0 is supported in https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/typescript-estree but we are already using 4.6.0 here, and there's an issue discussing upgrading to 4.8.0 in the repo, and the tests appear to pass fine with 4.7.0. |
the error message is completely correct you're using a ridiculously old (>10 months) version of the parser. |
Signed-off-by: Christian Stewart <[email protected]>
Signed-off-by: Christian Stewart <[email protected]>
@bradzacher Ok, trying to update it. Thanks. It's really annoying how "npm outdated" and "yarn outdated" don't flag these. |
it's not flagged when you run outdated here because it's a transitive dependency. |
It seems that eslint-config-standard-with-typescript is holding this up... they merged a renovate bot patch which upgrades the parser, but have not tagged a new release. Blocked until they tag a new release unfortunately... mightyiam/eslint-config-love#831 |
"tempy": "^2.0.0", | ||
"typescript": "^4.6.3", | ||
"tempy": "^3.0.0", | ||
"typescript": "^4.7.4", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"typescript": "^4.7.4", | |
"typescript": "4.7.x", |
This being a range in the first place is a mistake - TypeScript doesn't follow semver so has a habit of releasing breaking changes as minors.
This LGTM, but (with the exception of tempy) the version bumps are in-range semver so shouldn't be necessary. How did you come to opening this PR? Do you have a lock file in your project that needs updating? |
triage note: blocked on resolving eslint 8 issues first (e.g. ipfs/eslint-config-ipfs#98) |
Superseded by #1164 - all deps are now up to date! |
Fixes an error when building where "es2021" is not in the list of known versions.
Refactor for import path changes required when upgrading to tempy 3.0.0