Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update typescript, esbuild, tempy #1007

Closed
wants to merge 5 commits into from

Conversation

paralin
Copy link

@paralin paralin commented Jun 22, 2022

Fixes an error when building where "es2021" is not in the list of known versions.

Refactor for import path changes required when upgrading to tempy 3.0.0

@paralin
Copy link
Author

paralin commented Jun 22, 2022

An error is logged saying TypeScript <= 4.5.0 is supported in https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/typescript-estree but we are already using 4.6.0 here, and there's an issue discussing upgrading to 4.8.0 in the repo, and the tests appear to pass fine with 4.7.0.

See: typescript-eslint/typescript-eslint#5227

@bradzacher
Copy link

bradzacher commented Jun 22, 2022

the error message is completely correct
https://github.com/ipfs/eslint-config-ipfs/blob/15cbb1d71ca054ed22a8c368fafdbc251750f023/package.json#L21

you're using a ridiculously old (>10 months) version of the parser.

@paralin
Copy link
Author

paralin commented Jun 22, 2022

@bradzacher Ok, trying to update it. Thanks. It's really annoying how "npm outdated" and "yarn outdated" don't flag these.

@bradzacher
Copy link

it's not flagged when you run outdated here because it's a transitive dependency.
if you were to run outdated in the eslint-config-ipfs folder it should show up

@paralin
Copy link
Author

paralin commented Jun 22, 2022

It seems that eslint-config-standard-with-typescript is holding this up... they merged a renovate bot patch which upgrades the parser, but have not tagged a new release.

Blocked until they tag a new release unfortunately...

mightyiam/eslint-config-love#831
mightyiam/eslint-config-love#792
mightyiam/eslint-config-love#840

@achingbrain achingbrain changed the title Update typescript, esbuild, tempy chore: update typescript, esbuild, tempy Jun 23, 2022
"tempy": "^2.0.0",
"typescript": "^4.6.3",
"tempy": "^3.0.0",
"typescript": "^4.7.4",
Copy link
Member

@achingbrain achingbrain Jun 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"typescript": "^4.7.4",
"typescript": "4.7.x",

This being a range in the first place is a mistake - TypeScript doesn't follow semver so has a habit of releasing breaking changes as minors.

@achingbrain
Copy link
Member

This LGTM, but (with the exception of tempy) the version bumps are in-range semver so shouldn't be necessary.

How did you come to opening this PR? Do you have a lock file in your project that needs updating?

@BigLep BigLep added the need/author-input Needs input from the original author label Jul 22, 2022
@achingbrain achingbrain changed the title chore: update typescript, esbuild, tempy fix: update typescript, esbuild, tempy Aug 10, 2022
@lidel
Copy link
Member

lidel commented Aug 12, 2022

triage note: blocked on resolving eslint 8 issues first (e.g. ipfs/eslint-config-ipfs#98)

@lidel lidel added status/blocked Unable to be worked further until needs are met and removed need/author-input Needs input from the original author labels Aug 12, 2022
@achingbrain
Copy link
Member

Superseded by #1164 - all deps are now up to date!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked Unable to be worked further until needs are met
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants