feat: support ESLint 8 #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates eslint-plugin-jsdoc and eslint-plugin-promise specifically, which are the only blockers for ESLint 8 adoption. Also fixes repository url
|
It seems there are some incompatible peer dependencies introduced by this PR - @DiegoRBaquero could you take a look please? |
|
Taking a look, blocked by mightyiam/eslint-config-love#792 |
BigLep
added
need/author-input
|
2022-05-27: we'll check back in on this in a week or two. If mightyiam/eslint-config-love#792 isn't resolved, we'll ask the author to unblock themselves by publishing a fork. |
|
2022-06-10: we will continue to let this sit given the active work in mightyiam/eslint-config-love#792 (comment) |
lidel
added
need/author-input
|
@DiegoRBaquero : given mightyiam/eslint-config-love#792 has been resolved, do we need to do any updates or just trigger the build again? |
|
Yes, the |
achingbrain
reviewed
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates eslint-plugin-jsdoc and eslint-plugin-promise specifically, which are the only blockers for ESLint 8 adoption. Also fixes repository url.
These changes seems to be non-breaking, i.e. still fully supported on ESLint 7