Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update typescript, esbuild, tempy #1007

Closed
wants to merge 5 commits into from
Closed

fix: update typescript, esbuild, tempy #1007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f2e8b5
chore(deps): upgrade tempy to 3.0.0
paralin Jun 22, 2022
8616d11
chore(deps): upgrade esbuild to 0.14.46
paralin Jun 22, 2022
65a1f8c
chore(deps): upgrade typescript to 4.7.4
paralin Jun 22, 2022
640235c
chore(deps): update eslint-config-ipfs to 2.1.2
paralin Jun 22, 2022
b44e564
chore(gitignore): add temporary tsconfig to ignore
paralin Jun 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,5 @@ yarn.lock
/docs
.nyc_output
*.log
.vscode
.vscode
/tsconfig-check.aegir.json
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,9 +224,9 @@
"detective-es6": "^3.0.0",
"electron-mocha-main": "^11.0.3",
"env-paths": "^3.0.0",
"esbuild": "^0.14.31",
"esbuild": "^0.14.46",
"eslint": "^8.12.0",
"eslint-config-ipfs": "^2.1.0",
"eslint-config-ipfs": "^2.1.2",
"eslint-plugin-etc": "^2.0.2",
"eslint-plugin-import": "^2.25.4",
"eslint-plugin-jsdoc": "^39.0.0",
Expand Down Expand Up @@ -272,8 +272,8 @@
"source-map-support": "^0.5.20",
"strip-bom": "^5.0.0",
"strip-json-comments": "^4.0.0",
"tempy": "^2.0.0",
"typescript": "^4.6.3",
"tempy": "^3.0.0",
"typescript": "^4.7.4",
Copy link
Member

@achingbrain achingbrain Jun 23, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"typescript": "^4.7.4",
"typescript": "4.7.x",

This being a range in the first place is a mistake - TypeScript doesn't follow semver so has a habit of releasing breaking changes as minors.

"uint8arrays": "^3.0.0",
"undici": "^5.0.0",
"update-notifier": "^5.0.0",
Expand Down
4 changes: 2 additions & 2 deletions src/test/node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { execa } from 'execa'
import path from 'path'
import tempy from 'tempy'
import { temporaryDirectory } from 'tempy'
import merge from 'merge-options'
import { fileURLToPath } from 'url'

Expand All @@ -24,7 +24,7 @@ export default async function testNode (argv, execaOptions) {
? [
'--reporter', 'json',
'--report-dir', '.coverage',
'--temp-directory', tempy.directory(),
'--temp-directory', temporaryDirectory(),
'--clean',
'mocha'
]
Expand Down
4 changes: 2 additions & 2 deletions test/build.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { expect } from '../utils/chai.js'
import { execa } from 'execa'
import fs from 'fs-extra'
import path, { join } from 'path'
import tempy from 'tempy'
import { temporaryDirectory } from 'tempy'
import { fileURLToPath } from 'url'
import { createRequire } from 'module'

Expand All @@ -17,7 +17,7 @@ describe('build', () => {
let projectDir = ''

before(async () => {
projectDir = tempy.directory()
projectDir = temporaryDirectory()

await fs.copy(join(__dirname, 'fixtures', 'projects', 'an-esm-project'), projectDir)
})
Expand Down
4 changes: 2 additions & 2 deletions test/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import { execa } from 'execa'
import fs, { copy } from 'fs-extra'
import path, { join } from 'path'
import tempy from 'tempy'
import { temporaryDirectory } from 'tempy'
import { fileURLToPath } from 'url'
import os from 'os'

Expand All @@ -13,7 +13,7 @@ const __dirname = path.dirname(fileURLToPath(import.meta.url))
* @param {string} project
*/
async function setUpProject (project) {
const projectDir = tempy.directory()
const projectDir = temporaryDirectory()

await copy(join(__dirname, 'fixtures', 'projects', project), projectDir)
const nodeModulesPath = path.resolve(__dirname, '../node_modules')
Expand Down