Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pre-commit issue #812

Merged
merged 141 commits into from
Mar 23, 2019
Merged

fix pre-commit issue #812

merged 141 commits into from
Mar 23, 2019

Conversation

FeirenK
Copy link
Contributor

@FeirenK FeirenK commented Mar 22, 2019

feiren.kuang and others added 20 commits March 17, 2019 09:52
fix  nightly_ioctl_build_darwin/docker
Get http://localhost:7788/liveness: dial tcp 127.0.0.1:7788: connect: connection refused
*  IOTEX-349 Reenable unit tests of ReadActiveBlockProducersByHeight and ReadCommitteeBlockProducersByHeight (#770)

* IOTEX-308 Add a gas price threshold and make default be 1 qev

* hotfix election out of boundary issue (#760)

* Name auto match for ioctl (#778)

* remove extra error output (#780)

* use time.Time as block time (#782)
error  7788  port
@FeirenK FeirenK requested a review from a team as a code owner March 22, 2019 03:38
install-cli.sh Outdated
@@ -62,7 +64,28 @@ downloadFile() {
exit 1
fi
}

install_golang() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to install golang...

@raullenchai raullenchai changed the title fix pre-commit issue && install-cli.sh golang depend fix pre-commit issue Mar 22, 2019
@raullenchai raullenchai merged commit 4bc8415 into iotexproject:master Mar 23, 2019
zjshen14 pushed a commit that referenced this pull request Mar 24, 2019
* Update config.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants