Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use time.Time as block time #782

Merged
merged 1 commit into from
Mar 20, 2019
Merged

use time.Time as block time #782

merged 1 commit into from
Mar 20, 2019

Conversation

CoderZhi
Copy link
Collaborator

tested it with make test && make minicluster

@CoderZhi CoderZhi requested a review from a team as a code owner March 20, 2019 00:03
zjshen14
zjshen14 approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@zjshen14 zjshen14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check why all mockgen has been updated?

@CoderZhi CoderZhi force-pushed the use_time_in_block branch from 6810670 to c3373f8 Compare March 20, 2019 04:27
@CoderZhi CoderZhi force-pushed the use_time_in_block branch from c3373f8 to 393a22c Compare March 20, 2019 04:29
@CoderZhi CoderZhi merged commit f5b3316 into iotexproject:master Mar 20, 2019
@CoderZhi CoderZhi deleted the use_time_in_block branch March 20, 2019 04:46
zjshen14 pushed a commit that referenced this pull request Mar 20, 2019
@CoderZhi @zjshen14
use time.Time as block time (#782)
df8a656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjshen14 zjshen14 zjshen14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CoderZhi @zjshen14