Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOTEX-349 Reenable unit tests of ReadActiveBlockProducersByHeight and ReadCommitteeBlockProducersByHeight #770

Merged
merged 2 commits into from
Mar 19, 2019

Conversation

lizhefeng
Copy link
Contributor

  1. Port hotfix of r0.5 on master
  2. Reenable API tests on reading active BPs and committee BPs

@lizhefeng lizhefeng requested a review from a team as a code owner March 19, 2019 02:37
@codecov
Copy link

codecov bot commented Mar 19, 2019

Codecov Report

Merging #770 into master will increase coverage by 0.04%.
The diff coverage is 25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #770      +/-   ##
==========================================
+ Coverage   59.59%   59.63%   +0.04%     
==========================================
  Files         133      133              
  Lines       11486    11484       -2     
==========================================
+ Hits         6845     6849       +4     
+ Misses       3756     3751       -5     
+ Partials      885      884       -1
Impacted Files Coverage Δ
server/itx/server.go 0% <0%> (ø) ⬆️
action/protocol/poll/protocol.go 20.9% <33.33%> (+0.72%) ⬆️
blockchain/blockchain.go 51.17% <0%> (+0.07%) ⬆️
consensus/scheme/rolldpos/rolldposctx.go 75.57% <0%> (+0.17%) ⬆️
db/trie/extensionnode.go 59.32% <0%> (+1.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e49c10a...3bd2426. Read the comment docs.

@lizhefeng lizhefeng merged commit 3d7bed5 into iotexproject:master Mar 19, 2019
zjshen14 pushed a commit that referenced this pull request Mar 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants