Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecations #519

Merged
merged 6 commits into from
Jan 22, 2021
Merged

Remove deprecations #519

merged 6 commits into from
Jan 22, 2021

Conversation

kierenevans
Copy link
Contributor

Helm and docker configurations have changed over time and we've maintained backwards compatibility.
As we prepare for v1.0.0, we should remove the backwards compatibility.

@kierenevans kierenevans added harness-php PHP harness harness-spryker Spryker harness breaking Breaking change, next major release only labels Jan 8, 2021
@kierenevans kierenevans added this to the 1.0 milestone Jan 8, 2021
@kierenevans kierenevans self-assigned this Jan 8, 2021
@@ -55,6 +55,8 @@ attributes:
DB_ADMIN_PASS: = @('database.root_pass')
resources:
memory: "2048Mi"
init_memory: "1024Mi"
migrate_memory: "1024Mi"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've done it another way on a project, but ok with this for now

Copy link
Contributor

@andytson-inviqa andytson-inviqa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more work to do for a 1.0.0 milestone but can be merged into a 1.0.0 branch

@kierenevans kierenevans changed the base branch from 0.12.x to 1.0.x January 12, 2021 13:00
@kierenevans kierenevans dismissed andytson-inviqa’s stale review January 12, 2021 13:00

The base branch was changed.

@kierenevans kierenevans marked this pull request as draft January 12, 2021 14:14
@kierenevans kierenevans marked this pull request as ready for review January 14, 2021 14:08
@kierenevans kierenevans added harness-all Changes required to all harness directories and removed harness-php PHP harness labels Jan 14, 2021
kierenevans added a commit that referenced this pull request Jan 14, 2021
@kierenevans kierenevans merged commit 74f835f into 1.0.x Jan 22, 2021
@kierenevans kierenevans deleted the feature/remove-deprecations branch January 22, 2021 09:19
kierenevans added a commit that referenced this pull request Jan 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, next major release only harness-all Changes required to all harness directories harness-spryker Spryker harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants