Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spryker after deprecations removed #524

Merged
merged 10 commits into from
Jan 14, 2021

Conversation

kierenevans
Copy link
Contributor

@kierenevans kierenevans commented Jan 14, 2021

Dynamically define attributes for per-store environment variables, rather than use a twig include. This allows us to have all environment variables written out to both docker and helm templates.

Spryker's helm values template is now the same as _base, after removing console.enabled (removed in #256), fixing resourcePrefix to use the attribute rather than workspace.name and updating the persistence attribute usage to be pipeline.base.persistence.

TODO:

  • Preview values.yaml updates

@kierenevans kierenevans added breaking Breaking change, next major release only harness-php PHP harness harness-spryker Spryker harness labels Jan 14, 2021
@kierenevans kierenevans added this to the 1.0.0 milestone Jan 14, 2021
@kierenevans kierenevans marked this pull request as ready for review January 14, 2021 11:27
Copy link

@hgajjar hgajjar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty neat 👍

@kierenevans kierenevans merged commit 8916ca4 into feature/remove-deprecations Jan 14, 2021
@kierenevans kierenevans deleted the feature/fix-spryker branch January 14, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change, next major release only harness-php PHP harness harness-spryker Spryker harness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants