Adjust spryker to use hostname_aliases for nginx #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kierenevans
added
bug
kierenevans
force-pushed
the
feature/move-spryker-to-use-hostname-aliases-for-nginx-and-ingress
branch
from
acb5a0f to
c41bc84
Compare
hgajjar
reviewed
Jan 22, 2021
hgajjar
reviewed
Jan 22, 2021
| annotations: | ||
| {{- range $key, $value := .Values.services.nginx.ingress.annotations }} |
There was a problem hiding this comment.
what do you think to moving .Values.services.nginx.ingress.annotations to .Values.ingress.annotations for the 1.0.0 release?
There was a problem hiding this comment.
I guess there might be annotations for the istio ingress too, though that can be switched at the values.yaml.twig level
There was a problem hiding this comment.
istio virtualservice only has labels atm, but I'd apply the annotation capability to both of them
There was a problem hiding this comment.
How does #538 look?
There was a problem hiding this comment.
It's now part of this PR :)
Replace hostname with namespace as domain is appended later
kierenevans
force-pushed
the
feature/move-spryker-to-use-hostname-aliases-for-nginx-and-ingress
branch
from
ae50510 to
744d808
Compare
Co-authored-by: andytson-inviqa <[email protected]>
andytson-inviqa
approved these changes
Jan 27, 2021
kierenevans
deleted the
feature/move-spryker-to-use-hostname-aliases-for-nginx-and-ingress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
within the nginx ingress for _base and spryker.Values.services.nginx.environment.FPM_HOST_HOST_in their name