Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rpc): null is deserialized as empty value for EventAttribute (abci v0_37) #1318

Closed
wants to merge 1 commit into from
Closed

fix(rpc): null is deserialized as empty value for EventAttribute (abci v0_37) #1318

wants to merge 1 commit into from

Conversation

xoac
Copy link

@xoac xoac commented May 22, 2023 •
edited
Loading

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@xoac xoac force-pushed the fix/latest-block-response branch from 05e554a to ef450c7 Compare May 22, 2023 07:43
@xoac xoac marked this pull request as ready for review May 22, 2023 07:44
@xoac xoac force-pushed the fix/latest-block-response branch from ef450c7 to 156a3a0 Compare May 22, 2023 08:24
@xoac xoac force-pushed the fix/latest-block-response branch from 156a3a0 to fe558d1 Compare May 22, 2023 13:04
mzabaluev
mzabaluev suggested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that the change does not match the title of the pull request. validator_updates is a field in ResponseEndBlock, isn't it?

Can you file an issue detailing the problem?

Also, it would be good to provide a test fixture, hopefully one obtained from a real-world node setup.

@xoac xoac closed this May 22, 2023
@xoac
Copy link
Author

xoac commented May 22, 2023 •
edited
Loading

@mzabaluev replaced this one with #1319 as the issue was that HttpClient ignore compact node when query v0.34 last block results.

I think this PR is also valid as value in EventAttribute can be explicitly null.

@xoac xoac changed the title fix(rpc): validator_updates in block results might be explicit null fix(rpc): null is deserialized as empty value for EventAttribute (abci v0_37) May 22, 2023
@mzabaluev
Copy link
Contributor

I think this PR is also valid as value in EventAttribute can be explicitly null.

I have not observed that with 0.37 yet, and I believe the serialization code in CometBFT has been changed to not produce null values. The 0.34 dialect deserialization does allow null, though. Can you provide an example where a null value is produced?

@xoac
Copy link
Author

xoac commented May 22, 2023

Probably my wrong assumption. For now I query only version 0.34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xoac @mzabaluev