Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rpc): null is deserialized as empty value for EventAttribute (abci v0_37) #1318

Closed
wants to merge 1 commit into from
+3 −0
Closed

fix(rpc): null is deserialized as empty value for EventAttribute (abci v0_37) #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/unreleased/bug-fixes/1318-deserialize_block_results.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- `[tendermint-rpc]` - null is deserialized as empty `value` for `EventAttribute` (abci v0_37)
2 changes: 2 additions & 0 deletions rpc/src/dialect/v0_37.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ use tendermint::{abci, evidence};
use tendermint_proto::v0_37 as raw;

use crate::prelude::*;
use crate::serializers;
use serde::{Deserialize, Serialize};

#[derive(Default, Clone)]
Expand Down Expand Up @@ -42,6 +43,7 @@ pub struct EventAttribute {
/// The event key.
pub key: String,
/// The event value.
#[serde(deserialize_with = "serializers::nullable::deserialize")]
pub value: String,
/// Whether Tendermint's indexer should index this event.
///
Expand Down