Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use compat mode when query latest_block_results #1319

Closed

Conversation

xoac
Copy link

@xoac xoac commented May 22, 2023

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@xoac xoac force-pushed the fix/use-compact-mode-last-results branch from 449c056 to 9562235 Compare May 22, 2023 16:44
@xoac xoac marked this pull request as ready for review May 22, 2023 16:46
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this!

@mzabaluev mzabaluev changed the title fix: use compact mode when query latest_block_results fix: use compat mode when query latest_block_results May 22, 2023
@mzabaluev mzabaluev added the bug Something isn't working label May 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #1319 (5746829) into main (bdef988) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

❗ Current head 5746829 differs from pull request most recent head 9562235. Consider uploading reports for the commit 9562235 to get more accurate results

@@           Coverage Diff           @@
##            main   #1319     +/-   ##
=======================================
- Coverage   59.0%   59.0%   -0.1%     
=======================================
  Files        281     281             
  Lines      25065   25068      +3     
=======================================
- Hits       14803   14800      -3     
- Misses     10262   10268      +6     
Impacted Files Coverage Δ
rpc/src/client/transport/http.rs 20.0% <0.0%> (-0.3%) ⬇️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xoac xoac requested a review from mzabaluev May 22, 2023 21:42
@mzabaluev
Copy link
Contributor

I'm sorry this has been let laying around. I've just re-done this in #1326, also fixing the WebSocketClient.

@mzabaluev mzabaluev closed this Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants