-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MsgConnOpenTry
builder and CLI
#388
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great stuff!
Left a few comments, and also ideas to potentially fix later.
Move temporarily to broadcast_tx_commit() to help with testing.
Codecov Report
@@ Coverage Diff @@
## master informalsystems/hermes#388 +/- ##
=========================================
+ Coverage 13.6% 35.1% +21.5%
=========================================
Files 69 150 +81
Lines 3752 9251 +5499
Branches 1374 3318 +1944
=========================================
+ Hits 513 3254 +2741
- Misses 2618 5771 +3153
+ Partials 621 226 -395
Continue to review full report at Codecov.
|
modules/src/ics04_channel/msgs.rs
Outdated
@@ -1,7 +1,6 @@ | |||
#![allow(clippy::too_many_arguments)] | |||
use super::channel::{ChannelEnd, Counterparty, Order}; | |||
|
|||
use crate::ics03_connection::connection::validate_version; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Following the recent PR , there may be major conflicts in file modules/src/ics04_channel/msgs.rs
, preventing the merge. From what I can tell, the modifications here are no longer relevant, so it's safe to choose the quick fix of leaving this file as it is on the master currently: https://github.com/informalsystems/ibc-rs/blob/master/modules/src/ics04_channel/msgs.rs (choose merging strategy theirs
I think).
PS: The changes here are small: basically you're removing any use of the ICS03::validate_version
method from what I can tell, and I'm doing the same changes in #391, so we will not lose these fixes.
* Initial commit for open try, updates to merkle and version, etc * add grpc for unbonding period * Added more version code and tests * cleanup * cargo fmt * Correct checks for destination connection. Move temporarily to broadcast_tx_commit() to help with testing. * Remove the tendermint generated files * review comments * Just use RawMerkleProof for now and remove the conversion shortcuts * moved CommitementProof deser/ser * fix status info and match in build proofs * forgotten changes after merge
Closes: #358
Description
raw tx conn-try
CLIConnTry
message that can be used with minimal changes from the relayerConnInit
and the client messages builders to allow usage from the relayerproven_..
queries that return proofsHeight
For contributor use:
docs/
) and code comments.Files changed
in the Github PR explorer.