You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Cosmos SDK does not allow "empty" version strings but ICS-03 and ICS-04 suggest using a default version of "" if needed.
A lot of places in code use Version string and require some validation on version -> String and versions -> Vec<String>. For now, this is handled by two functions which are part of Connection module in code and this is simply to get the work done fast but this needs to be discussed on how we want to do it moving forward.
Proposed Solution
I suggest we adhere to the ICS-es to allow empty version strings and raise an issue about this on the SDK side.
I think it will be helpful to have a concrete Version type with its own implementation. I remember @ancazamfir saying this was being discussed and that it's not clear yet.
The text was updated successfully, but these errors were encountered:
Problem
""
if needed.Version
string and require some validation onversion
->String
andversions
->Vec<String>
. For now, this is handled by two functions which are part of Connection module in code and this is simply to get the work done fast but this needs to be discussed on how we want to do it moving forward.Proposed Solution
The text was updated successfully, but these errors were encountered: