You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think it would be nicer if these two methods get_compatible_versions() and msg.counterparty_versions() both return domain type objects Vec<Version> (instead of vector of strings). Then we can also avoid doing the conversion inside pick_version, and pick version would only be concerned with the logic of computing intersection and picking version.
I agree. Started to do the changes earlier but they are more involved and was thinking to do it in a separate PR. However if you feel I should do it here let me know and will start on it.
I think it would be nicer if these two methods
get_compatible_versions()
andmsg.counterparty_versions()
both return domain type objectsVec<Version>
(instead of vector of strings). Then we can also avoid doing the conversion inside pick_version, and pick version would only be concerned with the logic of computing intersection and picking version.Originally posted by @adizere in informalsystems/hermes#388 (comment)
I agree. Started to do the changes earlier but they are more involved and was thinking to do it in a separate PR. However if you feel I should do it here let me know and will start on it.
Originally posted by @ancazamfir in informalsystems/hermes#388 (comment)
The text was updated successfully, but these errors were encountered: