Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor versions methods in ICS03 #99

Closed
adizere opened this issue Nov 10, 2020 · 1 comment
Closed

Refactor versions methods in ICS03 #99

adizere opened this issue Nov 10, 2020 · 1 comment
Labels
O: new-feature Objective: aims to add new feature

Comments

@adizere
Copy link
Contributor

adizere commented Nov 10, 2020

I think it would be nicer if these two methods get_compatible_versions() and msg.counterparty_versions() both return domain type objects Vec<Version> (instead of vector of strings). Then we can also avoid doing the conversion inside pick_version, and pick version would only be concerned with the logic of computing intersection and picking version.

Originally posted by @adizere in informalsystems/hermes#388 (comment)

I agree. Started to do the changes earlier but they are more involved and was thinking to do it in a separate PR. However if you feel I should do it here let me know and will start on it.

Originally posted by @ancazamfir in informalsystems/hermes#388 (comment)

@adizere adizere added the O: new-feature Objective: aims to add new feature label Nov 10, 2020
@ancazamfir
Copy link
Collaborator

Closed via informalsystems/hermes#449

@hu55a1n1 hu55a1n1 transferred this issue from informalsystems/hermes Sep 29, 2022
shuoer86 pushed a commit to shuoer86/ibc-rs that referenced this issue Nov 4, 2023
Bump minimum supported Rust version to 1.56.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O: new-feature Objective: aims to add new feature
Projects
None yet
Development

No branches or pull requests

2 participants