This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
feat: replace cloud_storage with custom implementation (#18) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustvold
force-pushed
the
replace-cloud-storage-sdk
branch
from
86f06b8
to
0655d60
Compare
tustvold
force-pushed
the
replace-cloud-storage-sdk
branch
from
0655d60
to
9986c50
Compare
tustvold
changed the title
tustvold
commented
Jul 1, 2022
|
|
||
| /// Encapsulates the logic to perform an OAuth token challenge | ||
| #[derive(Debug)] | ||
| pub struct OAuthProvider { |
There was a problem hiding this comment.
This will also be useful for Azure which similarly adopts standard authentication practices. AWS unfortunately is a special snowflake here, as per usual
|
Now that we have our own impl, we could probably also test against an emulator. The only reason that GCP wasn't tested was due to ThouCheese/cloud-storage-rs#96 (AWS and Azure are tested). |
crepererum
approved these changes
Jul 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #43
Closes #22
Part of #18
This replaces cloud_storage with a simple implementation based on reqwest (not a new dependency). Ultimately I would like to give the same treatment to all the SDKs, as it gives us more control and reduces the dependency explosion.