Make ring optional and cleanup tests #2344
Conversation
| @@ -46,9 +46,9 @@ serde = { version = "1.0", default-features = false, features = ["derive"], opti | |||
| serde_json = { version = "1.0", default-features = false, optional = true } | |||
| quick-xml = { version = "0.23.0", features = ["serialize"], optional = true } | |||
| rustls-pemfile = { version = "1.0", default-features = false, optional = true } | |||
| ring = { version = "0.16", default-features = false, features = ["std"] } | |||
| ring = { version = "0.16", default-features = false, features = ["std"], optional = true } | |||
There was a problem hiding this comment.
This was purely an oversight in influxdata/object_store_rs#42
| @@ -1250,32 +1219,16 @@ mod tests { | |||
| }}; | |||
| } | |||
|
|
|||
| fn check_credentials<T>(r: Result<T>) -> Result<T> { | |||
There was a problem hiding this comment.
This has been broken since the move to an object-safe ObjectStore, and isn't really providing meaningful value - lets just remove it
| type Error = Box<dyn std::error::Error + Send + Sync + 'static>; | ||
| type Result<T, E = Error> = std::result::Result<T, E>; | ||
|
|
||
| pub(crate) async fn put_get_delete_list(storage: &DynObjectStore) -> Result<()> { |
There was a problem hiding this comment.
This pattern of bubbling up the error loses the context of where the error occurred, and just makes things confusing
| type Error = Box<dyn std::error::Error + Send + Sync + 'static>; | ||
| type Result<T, E = Error> = std::result::Result<T, E>; |
There was a problem hiding this comment.
These type aliases have caught me out many times, very happy to see them gone
|
Benchmark runs are scheduled for baseline = 5fae299 and contender = f3baeaa. f3baeaa is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?