Add DownloadRequestBuilder for more complex download support #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
download
anddownload_streamed
treat not found errors differentlyProposal
This PR therefore implements a new
ObjectClient::download_request
method that returns aDownloadRequestBuilder
which allows constructing a request with additional options, and then either collecting the results into a singleBytes
or streaming the HTTP chunks as they are sent on the wire. This approach will provide an obvious extension point for future possibilities, like requesting a specific object generation, conditional matches, etc...ObjectClient::download
andObjectClient::download_streamed
are then updated to use this builder.Let me know what you think 😄
This pattern could also be applied to other methods such as create() to allow setting metadata, ACLs, content-encoding, etc...