This repository has been archived by the owner on May 21, 2024. It is now read-only.
RFC3164 support old syslog #55
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both nontransparent and octetcounting use RFC5424 which isn't used by many devices, i.e. OpenWrt or Ubiquiti routers. Add a new function called NewParserRFC3164 to both. Signed-off-by: Paul Spooren <[email protected]>
…c3164-openbsd Regenerate rfc3164/machine.go
OpenBSD like many other hardware sends syslog messages without hostname, here I added support of such messages.
Some old syslog may add LF between two messages, outside of counters.
This, it added missed WithMaxMessageLength into .rl
It is qutie confusing when it parses a message but returns error as well, that it was mallforemd. So, I've used the best effort flag as the way to decide. When it true, it gnores all errors, but when it false it ignores the message.
Move changes to nontransparent/parser.go.rl and regenerate nontransparent/parser.go
catap
added a commit
to catap/loki
that referenced
this pull request
Apr 28, 2024
4 tasks
Unifi thinks that it can be up to 48 characters, tolerate it.
catap
added a commit
to catap/loki
that referenced
this pull request
Apr 29, 2024
|
@leodido any chance to review this series of commit? it should unblock support of BSD syslog inside Loki which will benefite to community in general. |
catap
added a commit
to catap/loki
that referenced
this pull request
Apr 30, 2024
|
Hey @catap, thanks for your effort! ❤️ I've decided to keep maintaining this project but on my GitHub account. So, please direct this pull request to https://github.com/leodido/go-syslog 🙏 |
|
@leodido thanks for takeing this back to life! I've openned the same PR as leodido/go-syslog#2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a PR with goal to support many different old syslog.
This changes allows to support:
Probably many other edge cases and hardware.
Thus, it includes: #46, #49 and #54