RFC3164 support old syslog #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
both nontransparent and octetcounting use RFC5424 which isn't used by many devices, i.e. OpenWrt or Ubiquiti routers. Add a new function called NewParserRFC3164 to both. Signed-off-by: Paul Spooren <[email protected]>
…c3164-openbsd Regenerate rfc3164/machine.go
OpenBSD like many other hardware sends syslog messages without hostname, here I added support of such messages.
Some old syslog may add LF between two messages, outside of counters.
This, it added missed WithMaxMessageLength into .rl
It is qutie confusing when it parses a message but returns error as well, that it was mallforemd. So, I've used the best effort flag as the way to decide. When it true, it gnores all errors, but when it false it ignores the message.
Move changes to nontransparent/parser.go.rl and regenerate nontransparent/parser.go
Unifi thinks that it can be up to 48 characters, tolerate it.
|
Closing in favor of #13 Thank you so much! This is awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here a PR with goal to support many different old syslog.
This changes allows to support:
Probably many other edge cases and hardware.
Thus, it includes: influxdata/go-syslog#46, influxdata/go-syslog#49 and influxdata/go-syslog#54
Originally it was opened as influxdata/go-syslog#55 but was requested to backport here as the most alive port.