fix(server): Does not assign lat/lon if they are at 0,0 #2991

[sellnat77]

Description

• Allows null input to parseLatitude and parseLongitude
  • Returns null
• If the latitude AND longitude are both 0, their exif coordinates are not set

Fixes #2991
Closes #3665

How Has This Been Tested?

• Edit picture metadata to have lat,lon (0,0) -> open map with default settings -> verify null island is empty

Screenshots (if appropriate):

Checklist:

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation if applicable

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
immich	⬜️ Ignored (Inspect)	Visit Preview		Aug 15, 2023 1:14am

[jrasm91]

Can we add a migration to fix existing data? Is that something you would be able to do? We can SQL update the data and set 0s to null on the next release.

[sellnat77]

I can try! Any hints on where to look for a previous example?

[jrasm91]

The src/infra/migrations folder

[jrasm91]

Here's the docs for them as well:

https://immich.app/docs/developer/database-migrations

[sellnat77]

Added migration file, not sure i did it right? specifically the down portion

When i transferred the migration to the dir the 0,0 entries were properly nulled out
if the down migration were to be ran, all the null entries would be placed on null island

[jrasm91]

Looks great. We don't need a down for this migration 😁

(You can leave it empty)

[JackBailey]

For anyone with this issue with imported files, here's how you perform the migration manually for docker installs:

docker exec -it immich-postgres psql --password --username immich-user immich-database

Enter your password, then run the following:

UPDATE "exif" SET latitude = NULL, longitude = NULL WHERE latitude = 0 AND longitude = 0;