Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): add showHidden toggle for null island on map page #2991 #3665

Closed
wants to merge 1 commit into from

Conversation

sellnat77
Copy link
Contributor

Description

  • Adds a showHidden toggle to map settings defaulted to false
  • Does not render images on the map if lat,lon = (0,0) and showHidden is false

Fixes #2991

How Has This Been Tested?

  • Edit picture metadata to have lat,lon (0,0) -> open map with default settings -> verify null island is empty
  • Edit picture metadata to have lat,lon (0,0) -> open map -> toggle showHidden to true -> verify image appears at null island

Screenshots (if appropriate):

Screenshot from 2023-08-13 11-30-44
Screenshot from 2023-08-13 11-27-03
Screenshot from 2023-08-13 11-20-06
Screenshot from 2023-08-13 11-19-51
Screenshot from 2023-08-13 11-19-18

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if applicable

@vercel
Copy link

vercel bot commented Aug 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
immich ⬜️ Ignored (Inspect) Visit Preview Aug 13, 2023 6:50pm

@bo0tzz
Copy link
Member

bo0tzz commented Aug 13, 2023

I'm not opposed to this approach, but maybe it would be better to ignore this bad data earlier in the process when it's being extracted from the exif?

@alextran1502
Copy link
Contributor

I agree with @bo0tzz, we should handle this data from the server side

@sellnat77
Copy link
Contributor Author

So maybe something like if the extracted exif is detected as (0,0) set it to null?

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we name this something else? Like ignoreZero / ignoreNullIsland 😛

@sellnat77
Copy link
Contributor Author

How about this approach?
#3669

@alextran1502
Copy link
Contributor

alextran1502 commented Aug 14, 2023

superseded by #3669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Map shows some pictures on Null Island
4 participants