Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Map shows some pictures on Null Island #2991

Closed
2 of 3 tasks
cfpwastaken opened this issue Jun 27, 2023 · 7 comments · Fixed by #3669
Closed
2 of 3 tasks

[BUG] Map shows some pictures on Null Island #2991

cfpwastaken opened this issue Jun 27, 2023 · 7 comments · Fixed by #3669

Comments

@cfpwastaken
Copy link

The bug

Some photos in my library have location data for Null Island. It is the exact center point of the map.
image
Pictures can have location data of 0 longitude, 0 latitude when the data gets stripped out or something went wrong trying to get the location when taking the picture.

The OS that Immich Server is running on

Alpine Linux, but it is dockerized, another image creator

Version of Immich Server

v1.64.0

Version of Immich Mobile App

v1.64.0 build.87

Platform with the issue

  • Server
  • Web
  • Mobile

Your docker-compose.yml content

version: "3"
services:
  immich:
    image: ghcr.io/imagegenius/immich:latest
    container_name: immich
    environment:
      - PUID=1000
      - PGID=1000
      - TZ=Europe/Berlin
      - DB_HOSTNAME=postgres
      - DB_USERNAME=postgres
      - DB_PASSWORD=postgres
      - DB_DATABASE_NAME=immich
      - REDIS_HOSTNAME=redis
      #- DISABLE_MACHINE_LEARNING=false
      #- DISABLE_TYPESENSE=false
      - DB_PORT=5432 #optional
      - REDIS_PORT=6379 #optional
      - REDIS_PASSWORD= #optional
      - CUDA_ACCELERATION=false #optional
    volumes:
      - ./config:/config
      - ./photos:/photos
      - ./ml:/config/machine-learning #optional
    ports:
      - 1034:8080
    restart: unless-stopped
  redis:
    image: redis
    ports:
      - 6379:6379
    container_name: redis
  postgres:
    image: postgres:14
    ports:
      - 5432:5432
    container_name: postgres14
    environment:
      POSTGRES_USER: postgres
      POSTGRES_PASSWORD: postgres
      POSTGRES_DB: immich
    volumes:
      - postgres:/var/lib/postgresql/data

volumes:
   postgres:

Your .env content

I put the environment vars in the docker compose file

Reproduction steps

1. Obtain a photo with Null Island location info
2. View the "Map" tab in Immich
3. See the issue in the middle of the map

Additional information

Immich should detect that 0,0 location data and just not show those photos on the Map.

@alextran1502
Copy link
Contributor

alextran1502 commented Jun 27, 2023

So you are expected to not show assets that have lat/long = 0,0?

@cfpwastaken
Copy link
Author

The only content I have right now I'd rather not share, Ill see if I find another example

@alextran1502
Copy link
Contributor

The only content I have right now I'd rather not share, Ill see if I find another example

No, I mean if assets have lat/lon at Null island, then you expect they are not shown on the map, correct?

@cfpwastaken
Copy link
Author

oh, yes I do. They should be hidden on the map.

@alextran1502
Copy link
Contributor

Got it, thank you

@GrMoney93
Copy link

I believe that there should be an option as to whether they are shown on the map or not.

Currently not all of my images are showing up on the map (Still processing all the machine learning), and it is useful for debugging purposes to know if they are missing or at null island? But default should be to not show, with the option to show hidden inside the "Map Settings".

@cfpwastaken
Copy link
Author

I suppose this makes sense.

sellnat77 added a commit to sellnat77/immich that referenced this issue Aug 13, 2023
alextran1502 pushed a commit that referenced this issue Aug 15, 2023
* fix(server): Does not assign lat/lon if they are at 0,0 #2991

* Adds migration file to fix null island rows

* Removed down migration

* Leave empty down function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants