Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cliui package #2411

Merged
merged 14 commits into from
May 5, 2022
Merged

feat: cliui package #2411

merged 14 commits into from
May 5, 2022

Conversation

ivanovpetr
Copy link
Contributor

Introducing cliui package, single point for terminal interaction.

Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ignite/cmd/cmd.go Outdated Show resolved Hide resolved
ignite/cmd/cmd.go Outdated Show resolved Hide resolved
ignite/cmd/generate_dart.go Show resolved Hide resolved
ignite/pkg/cliui/cliui.go Show resolved Hide resolved
ignite/pkg/cliui/cliui.go Outdated Show resolved Hide resolved
ignite/pkg/events/events.go Outdated Show resolved Hide resolved
ignite/pkg/events/events.go Show resolved Hide resolved
ignite/pkg/events/events.go Outdated Show resolved Hide resolved
ignite/pkg/events/events.go Show resolved Hide resolved
ignite/pkg/cliui/cliui.go Show resolved Hide resolved
ignite/cmd/network.go Outdated Show resolved Hide resolved
@ivanovpetr ivanovpetr self-assigned this Apr 27, 2022
@ivanovpetr ivanovpetr marked this pull request as ready for review April 27, 2022 14:49
ivanovpetr and others added 2 commits April 27, 2022 18:49
Conflicts:
	ignite/cmd/network_request_list.go
Copy link
Member

@ilgooz ilgooz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

ignite/cmd/network_campaign_list.go Outdated Show resolved Hide resolved
ignite/cmd/network.go Show resolved Hide resolved
ignite/cmd/network_campaign_publish.go Show resolved Hide resolved
ignite/cmd/network_campaign_update.go Outdated Show resolved Hide resolved
ignite/cmd/network_chain_init.go Show resolved Hide resolved
ignite/cmd/network_chain_init.go Outdated Show resolved Hide resolved
ignite/cmd/network_chain_init.go Outdated Show resolved Hide resolved
ignite/cmd/network_chain_install.go Outdated Show resolved Hide resolved
ignite/cmd/network_chain_show_genesis.go Show resolved Hide resolved
ignite/pkg/cliui/cliui.go Outdated Show resolved Hide resolved
@ivanovpetr ivanovpetr requested a review from ilgooz April 29, 2022 11:54
@ivanovpetr ivanovpetr requested a review from ilgooz May 2, 2022 11:24
Conflicts:
	ignite/cmd/network_chain_publish.go
@ilgooz ilgooz merged commit 5f502e1 into develop May 5, 2022
@ilgooz ilgooz deleted the cliui branch May 5, 2022 11:19
Jchicode pushed a commit to Jchicode/cli that referenced this pull request Aug 9, 2023
* cliui 1st iteration

* cliui refactor network commands

* fix lint

* configure bus channel size with option

* fix events tests

* add spinner options

* revert import formatting

* fix events tests again

* fix spinner

* do review fixes

Co-authored-by: Petr Ivanov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants