Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a pkg/cliprint package #2213

Closed
ilgooz opened this issue Mar 24, 2022 · 2 comments · Fixed by #2411
Closed

create a pkg/cliprint package #2213

ilgooz opened this issue Mar 24, 2022 · 2 comments · Fixed by #2411
Assignees
Labels
Milestone

Comments

@ilgooz
Copy link
Member

ilgooz commented Mar 24, 2022

This packet should manage clispinner as well as printing something to the stdout(can be customized). This way it can stop the spinner before printing persistent text.

This will also fix this concurrency issue: Sometimes when you fmt.Println, it gets printed before the events are printed in the pipeline. cliprint, will do some sort of queue by using a channel to print events or fmt.Printlns (generics can be used for the channel type to support both kind)

@ilgooz ilgooz added type:feat To implement new feature. type:refactor labels Mar 24, 2022
@ilgooz ilgooz changed the title create a pkg/cliprint package create a pkg/cliprint package Mar 24, 2022
@ilgooz ilgooz added the type:bug Something isn't working label Mar 24, 2022
@ilgooz ilgooz added this to the T1 milestone Mar 24, 2022
@ivanovpetr
Copy link
Contributor

This package have a much bigger scope than just a concurrency problem. We already have a few issues for cli output improvement #1079, #1982, #2060 . I consider to make this issue a place to discuss ideas about a new cli output package.

@ivanovpetr
Copy link
Contributor

Move concurrency bug to another issue #2391

@ivanovpetr ivanovpetr removed the type:bug Something isn't working label Apr 19, 2022
@ivanovpetr ivanovpetr linked a pull request Apr 27, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants