Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clispinner conflicts with regular output functions #2391

Closed
ivanovpetr opened this issue Apr 19, 2022 · 0 comments · Fixed by #2411
Closed

Clispinner conflicts with regular output functions #2391

ivanovpetr opened this issue Apr 19, 2022 · 0 comments · Fixed by #2411
Assignees
@ivanovpetr
Labels
type:bug Something isn't working type:refactor
Milestone
T1

Comments

@ivanovpetr
Copy link
Contributor

Describe the bug
Sometimes clispinner conflicts with regular fmt print functions they are running in different goroutines and have "race condition" over output. This way output is broke from time to time

How to fix
If cmd is using clispinner make sure it is synchronised with fmt print functions.
@ivanovpetr ivanovpetr added type:bug Something isn't working type:refactor labels Apr 19, 2022
@ivanovpetr ivanovpetr changed the title Clispinner conflicts with regular output functions. Clispinner conflicts with regular output functions Apr 19, 2022
@ivanovpetr ivanovpetr mentioned this issue Apr 19, 2022
Closed
@ivanovpetr ivanovpetr self-assigned this Apr 20, 2022
@ivanovpetr ivanovpetr linked a pull request Apr 21, 2022 that will close this issue
refactor: fix events concurrency conflicts #2400
Closed
@ilgooz ilgooz modified the milestones: Next, T1 Apr 25, 2022
@ilgooz ilgooz linked a pull request Apr 26, 2022 that will close this issue
feat: cliui package #2411
Merged
@ilgooz ilgooz removed a link to a pull request Apr 26, 2022
feat: cliui package #2411
Merged
@ivanovpetr ivanovpetr linked a pull request Apr 27, 2022 that will close this issue
feat: cliui package #2411
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivanovpetr ivanovpetr

Labels
type:bug Something isn't working type:refactor
Projects
None yet
Milestone
T1
Development

Successfully merging a pull request may close this issue.

feat: cliui package ignite/cli
refactor: fix events concurrency conflicts ignite/cli
2 participants
@ilgooz @ivanovpetr