Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: improve output of serve #1079

Closed
fadeev opened this issue May 4, 2021 · 5 comments
Closed

Proposal: improve output of serve #1079

fadeev opened this issue May 4, 2021 · 5 comments
Assignees
Labels
type:feat To implement new feature.
Milestone

Comments

@fadeev
Copy link
Contributor

fadeev commented May 4, 2021

I propose we get rid of emojis in the output and tweak the formatting.

[✓] Detecting version: v0.40.0 (or above)
[✓] Building proto files
[✓] Installing dependencies
[✓] Building the source code
[✓] Initializing blockchain node
--------------------------------------------------------------------------------
Account created: alice
Address: cosmos16ngv79l9u980aj4j6juz7d98ykzgj9ym94xj9f
Mnemonic: debris robust bicycle hazard figure matrix soda chat inch jungle
twenty arena draft since demand column notice lumber dilemma pencil style
despair title husband
--------------------------------------------------------------------------------
Account created: alice
Address: cosmos16ngv79l9u980aj4j6juz7d98ykzgj9ym94xj9f
Mnemonic: debris robust bicycle hazard figure matrix soda chat inch jungle
twenty arena draft since demand column notice lumber dilemma pencil style
despair title husband
--------------------------------------------------------------------------------
[✓] Writing genesis transaction: /home/gitpod/.hello/config/gentx/gentx-ec305ecff7cf47db4f500041cba396ed2a64eb8a.json
[✓] Started a blockchain node: http://localhost:1317

[✓] Exporting genesis
[✓] Genesis exported: /home/gitpod/.starport/local-chains/hello/exported_genesis.json
[ ] Building proto...

When an action is in progress, we show the ellipsis .... Once it's done, we remove the ellipsis and check the box.

Another change is that we print out only :1317 where we host the swagger.

@lumtis
Copy link
Contributor

lumtis commented May 4, 2021

I like it. Particularly the accounts output, the one we currently have is a bit messy

@fadeev
Copy link
Contributor Author

fadeev commented Nov 19, 2021

Updated, simpler format:

$ starport c serve

Installing binary: /home/alice/go/bin/chaind
Initializing data directory: /home/alice/.chaind/

Creating account: alice
Address: cosmos16ngv79l9u980aj4j6juz7d98ykzgj9ym94xj9f
Mnemonic: debris robust bicycle hazard figure matrix soda chat inch jungle
twenty arena draft since demand column notice lumber dilemma pencil style
despair title husband

Creating account: bob
Address: cosmos16ngv79l9u980aj4j6juz7d98ykzgj9ym94xj9f
Mnemonic: debris robust bicycle hazard figure matrix soda chat inch jungle
twenty arena draft since demand column notice lumber dilemma pencil style
despair title husband

Exporting genesis state: /Users/fadeev/.starport/local-chains/chain/exported_genesis.json

Restarting the node from a saved state.

Starting node RPC: https://localhost:26657
Starting node API: https://localhost:1317
Starting token faucet: https://localhost:4500

Block height: 467, txs: 3, time: 2021-11-18T12:56:27.336748Z.

The last line updates every time a new block is generated. The format can be different, but the goal is not to fill the whole screen with block height info, but just to replace the last line. If a module logs something, we can send it to the output and then start printing latest block info.

[foomodule] logging something!

Block height: 469, txs: 2, time: 2021-11-18T12:56:27.336748Z.

@ilgooz
Copy link
Member

ilgooz commented May 10, 2022

This will be addressed by #2420.

@ilgooz ilgooz closed this as completed May 10, 2022
@ilgooz ilgooz reopened this May 10, 2022
@ilgooz
Copy link
Member

ilgooz commented May 10, 2022

Here is another design idea: #2420 (comment)

@ivanovpetr
Copy link
Contributor

Closed in favor of #2458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feat To implement new feature.
Projects
None yet
Development

No branches or pull requests

4 participants