-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Remove command line option --no-xinclude #32
Conversation
Command line option `--no-xinclude` has no effect since the move to xml2rfc from rfctools-common.
Command line option `--no-xinclude` has no effect since the move to xml2rfc from rfctools-common.
This breaks @martinthomson's i-d-template, because that uses |
It would be good to add some test cases, one of which should be the rendering of an I-D with |
It's @cabo's kramdown-rfc that uses -X, I believe. |
This. |
I have a PR reintroduce this with a warning because it's no-ops: #35 |
Ping? |
This is done and released isn't it? |
Well, svgcheck still fails, but this seems to be because it can't read from stdin. |
kramdown-rfc 1.6.24 now working around the stdin issue. |
Apologies for thinking we hadn't fixed this yet -- the new regression was reported to me on the same github issue the X was on. I still think that tools like this shouldn't change their CLI willy-nilly, neither losing an option (and then erroring out on it), nor losing the ability to read stdin. |
Sorry, It was an unintentional mistake to remove STDIN functionality. |
Command line option
--no-xinclude
has no effect since the move to xml2rfc from rfctools-common.