Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svgcheck 0.7.0 dropped -X #364

Closed
larseggert opened this issue Jan 31, 2023 · 4 comments
Closed

svgcheck 0.7.0 dropped -X #364

larseggert opened this issue Jan 31, 2023 · 4 comments

Comments

@larseggert
Copy link
Contributor

See ietf-tools/svgcheck#32.

@snorp
Copy link
Contributor

snorp commented Feb 22, 2023

Yeah, and in 0.7.1 there doesn't even seem to be an error printed for that? I get the following right now.

** Not using persistent HTTP -- cannot load such file -- net/http/persistent
**   To silence this message and get full speed, try:
**     gem install net-http-persistent
**   If this doesn't work, you can ignore this warning.
*** [svgcheck:] Traceback (most recent call last):
*** [svgcheck:]   File "/usr/local/google/home/jwillcox/tigress/lib/.venv/bin/svgcheck", line 8, in <module>
*** [svgcheck:]     sys.exit(main())
*** [svgcheck:]   File "/usr/local/google/home/jwillcox/tigress/lib/.venv/lib/python3.10/site-packages/svgcheck/run.py", line 122, in main
*** [svgcheck:]     parser = XmlRfcParser(source, verbose=options.verbose,
*** [svgcheck:]   File "/usr/local/google/home/jwillcox/tigress/lib/.venv/lib/python3.10/site-packages/xml2rfc/parser.py", line 500, in __init__
*** [svgcheck:]     with io.open(self.source, "rb", newline=None) as f:
*** [svgcheck:] FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/google/home/jwillcox/tigress/stdin'
*** could not create svg for "       ┌──────┐    ...
Error: Unable to parse the XML document: /dev/stdin

We should follow up with kramdown-rfc, but for now maybe we should just lock to the last known-good version, 0.6.2.

@snorp
Copy link
Contributor

snorp commented Feb 22, 2023

cabo/kramdown-rfc#187

@snorp
Copy link
Contributor

snorp commented Feb 22, 2023

The error above is a separate regression in svgcheck. It has been worked around in the latest kramdown-rfc, but it looks like we need to rebuild the Docker images to get that. @martinthomson can you kick something?

@martinthomson
Copy link
Owner

Boot applied. Should be good in about 10 minutes, slightly longer if there is a build failure and I have to kick it again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants