Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ability to use STDIN #36

Closed
kesara opened this issue Feb 22, 2023 · 5 comments · Fixed by #56
Closed

Restore ability to use STDIN #36

kesara opened this issue Feb 22, 2023 · 5 comments · Fixed by #56
Labels
bug Something isn't working

Comments

@kesara
Copy link
Member

kesara commented Feb 22, 2023

Restore ability to use standard input for svgcheck.
This functionality was unintentionally removed in #28.

@kesara kesara added the bug Something isn't working label Feb 22, 2023
@larseggert
Copy link

We need a test suite :-)

@kesara
Copy link
Member Author

kesara commented Feb 23, 2023

We need a test suite :-)

I assume that you are talking about a test suite that covers all popular tools used by the community.

@rjsparks
Copy link
Member

I really hope the path to redefining what svg is acceptable is opening. It would be a much better investment to build a more maintainable checker against those rules than continuing to build infrastructure around a set of rules we know we're going to leave. (And to be explicit, I would expect to write something new for those rules rather than adjust this current implementation).

@hoehrmann
Copy link

The problem is this line

source = os.getcwd() + "/stdin"
- it looks for a "stdin" file in the current working directory instead of reading from the moral equivalent of /dev/stdin.

(Via cabo/kramdown-rfc#233)

@rfc2822
Copy link

rfc2822 commented Sep 28, 2024

(Via cabo/kramdown-rfc#233)

Replacing the line in run.py by

    if len(args) < 1:
        source = "/dev/stdin"

as mentioned there works for me.

kesara added a commit to kesara/svgcheck that referenced this issue Sep 30, 2024
kesara added a commit to kesara/svgcheck that referenced this issue Oct 3, 2024
kesara added a commit that referenced this issue Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants