Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

187912756/verify identity 1 previous step button missing #3997

Closed
wants to merge 193 commits into from
Closed

187912756/verify identity 1 previous step button missing #3997

wants to merge 193 commits into from

Conversation

bbodine1
Copy link
Contributor

@bbodine1 bbodine1 commented Jul 5, 2024

scaustin34 and others added 30 commits June 26, 2024 13:12
@scaustin34
upgrade to bs4 base
ad75f34
@scaustin34
revert temp changes for design review to trunk
b55bb12
@scaustin34
add feature flag and switch consumer role controler layout
6259214
@kristinmerbach @scaustin34
personal information page redo
7952d22
@kristinmerbach @scaustin34
feature flags, faa layouts
13c4475
@scaustin34
bs4 footer
1417005
@scaustin34
fix for dynamic footer
93741e9
@scaustin34
header wip, stable
90f794d
@scaustin34
header progress
9ce68d2
@scaustin34
sticky footer fix
7719622
@scaustin34
header logo update, move styling to new file
1abd12e
@scaustin34
add bs4 upgrade icons, collapsed header tweaks
a1d01bb
@kristinmerbach @scaustin34
started family information
9b5c6a2
@kristinmerbach @scaustin34
privacy page and personal information, button mixin
0be2cda
@kristinmerbach @scaustin34
registration process
15c6d1a
@kristinmerbach @scaustin34
more work on consumer flow
d2823ce
@scaustin34
fix semicolon
9bbfb32
@kristinmerbach @scaustin34
client specific files re-organized
7e76cf1
@kristinmerbach @scaustin34
authorization & consent page
db1327a
@scaustin34
footer updates
df10f2e
@scaustin34
footer phone # fix
3502715
@kristinmerbach @scaustin34
authority & consent ridp page
f4878c6
@kristinmerbach @scaustin34
progress nav accessibility
cae0924
@kristinmerbach @scaustin34
fix fonts, more ridp work started
7a2bbce
@scaustin34
added ME colors, revert app controller flag
3aa3422
@kristinmerbach @scaustin34
ridp flow
f0e4bc7
@kristinmerbach @scaustin34
add new progress layout
1165fb9
@kristinmerbach @scaustin34
create account page plus additional translations
8a9e5c2
@kristinmerbach @scaustin34
immigration doc partials
0d819e4
@kristinmerbach @scaustin34
translations for other clients
567deab
charlienparker and others added 25 commits June 26, 2024 13:16
@charlienparker @scaustin34
fix disable link (#3969)
0cb2969
@charlienparker @scaustin34
bs4 income adjustments (#3954)
714bed1 
* todos

* add red required asterisk

mc

* remove date debug comments

* remove newline

* more section work

mc

* work through coverage

mc

* remove hack for frozen string and update displayable_field?

mc

* add income table

* translation work, use existing gray colors for table borders

mc

* modal work

* fix modal id

* modal title fix

* continue text for mec banner

* coverage required fixes

mc

* move caretaker string to review section

mc

* translation cleanup

* more localization work

mc

* fix hover color

* fix asterisk

* m
mcodernize review_benefits partial (need to remove debug)

* debug removal, translation esi work

mc

* move esi fields to partial

* add bottom sections

mc

* fix formatted string

* add subsection partial

* pass in applicant for summary section

mc

* move hash helpers to new file

mc

* add translation helper for review and submit hashes

mc

* add private helpers for displayable field and add missing row map calls for foster care keys

* move translator module into helper module, fix displayable helper callers for applicant

* cleanup

mc

* use key for expected

* fix caretaker key, view cleanup

mc

* use human boolean for parent outside

* undo rebase issue

* fix continue application content

* add missing upcase

* undo lock file change

* update hover

* remove todo

* titleize relationship, add helpers for hash constructors

* classify displayable helpers

* remove class_name method

* add include, fix wrong variable name for relationship builder

* remove unneeded helper declaration

* remove newline

Signed-off-by: Charlie Parker <[email protected]>

* add bs4 outline to view, logic to controller

mc

* inital review work - update controller to support action, implement Personal Info and Tax rows

mc

mc

* fix for review and submit layout

mc

* move selectric handling to js for other questions

* initial page work

mc

* update form, update date formatting for date fields, disable selectric on drop downs

* save cancel button work

* remove debug

* remove unneeded ids, fix error on translations but still need correct content

mc

* add nav, update form partial to default save button to disabled

* fix save button and form disabling

* fix add more link permeance after removal

* fix created income UI showing legacy, fix edit button not working

* remove unneeded bs4 set

* move other actions to conditional

mc

* add date field for income, fix bug causing fake input fields to be enabled upon edit -> cancel flow

* use date field for unemployment

* fix add button permeance bug after remove for unemployment

mc

* cleanup

mc

* update disable for deductions

* cleanup

* cancel fix, other income form class fixes

* fix cancel button reseting checkbox bug, update padding for elements in form partials to be consistent with non-form partials

* update edit and remove buttons for deductions, remove repeated edit class for other income

* swap id and class for add more button in both legacy and bs4

* add missing enable from rebase

* add missing when from rebase

* fix destroy/destroy all handling to ensure permeance of add new button when there are still other deductions for the kind, fix replace bug that caused the add new button to be hidden when adding a new deduction after deleting a deduction

* update add new button hiding

* button fixes - use outline for remove and use button class for edit to allow edit disabling

* remove add more on destroy all

* modal and translation work

* add logic to reset deduction form when empty and uncheck

* edit, cancel, add new fixes for other income

* fix deduction remove not causing checkbox reset, break out deduction kind remove to function, refactor deduction kind remove to handle concurrency

* disable all income edit buttons while editing for other/unemployment along with class update to btn to allow disable, start selector syntax fix for removeDeduction method, add removeIncome method, add other income checkbox uncheck handling for no created deductions case, button styling fix for modals

* support add new disable for unemployment, remove unneeded selector from replace, margin fixes for unemployment cancel and unemployment add more

* support add more disable for other income

* margin fixes for buttons, apply other income add disable universally

* add more fixes

* add progress button disable functionality

* fix new form permeating when removing all deduction kinds, fix add more permeating when unchecking kind with open form

* fix other income add more permeating when unchecking kind with an income and form, fix doubling up of income when creating income after removing all kind with an income and form

* cleanup cancel, fix unemployment add more to not appear for initial entry

* remove cleanup

* add legacy handling for deductions

* hide add more on cancel when no other existing

* auto uncheck unemployment on final delete, fix cancel handling

* fix add more permeance for cancel new deduction, break out reset into function, update income edit disabling to account for unemployment

* selector fixes, make frequency required

* update modals and allow disabling of a tags

* fix broken translation

* translation cleanup for me, remove labels from subsection partial and replace with dl, add required class for dt

* rename key string

* remove unneeded style

* remove unused strings

* update margins of form buttons and checkboxes to match mockups

* remove add new deduction bottom margin, add x margin for deduction/other driver radios, update deduction form edit/create to disable remove button of other forms

* restructure other markup, update save input class to button to match disabled styling, disable remove button for income.js when editing

* class fixes

* update edit toggling selectors to not disable divs which directly own buttons

* ss string fix

* fix leave warning modal

* cleanup

* add support for ai an

* set deductions actions from params

* restore legacy add replace

* consolidate add link

* update disabled style to select all bottom level, non a & button elements so that a & buttons can be individually styled, update new form cloning to prevent multiple form label error

* remove debug

* comment fixes

* update forms to validate date warnings using bs4 date format, add date warning UI for bs4, update date warning content to match mockups

* fix date parsing for bs4

* income note field work

* add end date translation

* fix syntax error

* remove unneeded keys from merge

* fix legacy income note

* translation cleanup

* update leave edit to not enable submit buttons, remove redundant disable on fake inputs

* more translation cleanup

* disable help links

* fix review description list

* cleanup

* fix unemployment edit delete

* fix date parsing

* update other questions date parsing

* modal work

* add date warning to other income, remove undefined check in js

* move warning partials

* flex work

* rollback debug

* remove extra semi colon

* disable yes/no text

* remove left margins on inputs

* more margin updates

* remove margin on unemployment add more

* add leave ids

---------

Signed-off-by: Charlie Parker <[email protected]>
@charlienparker @kristinmerbach @scaustin34
update sep page for bs4 (#3902)
eda8a9d 
* personal information page redo

mc

* mc

* mc

* mc

* feature flags, faa layouts

mc

mc

* header progress

mc

* add bs4 upgrade icons, collapsed header tweaks

mc

* started family information

mc

mc

* registration process

mc

* more work on consumer flow

mc

mc

* client specific files re-organized

mc

* footer updates

mc

* authority & consent ridp page

mc

* progress nav accessibility

mc

* fix fonts, more ridp work started

mc

* added ME colors, revert app controller flag

mc

* ridp flow

mc

* don't touch FAA yet

mc

mc#

mc

* starting to rubocop

mc

* fix brakeman, other text changes

mc

* reformat devide translations

mc

* id bad bullets

mc

* id bad bullet

mc

* id bad bullet

mc

* previous and continue buttons dryed out

mc

* fix auth and consent previous button layout (#3825)

* wrap progress button in vertically aligned flex box

* combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality

* remove unneeded div

* remove unneeded argument

mc

mc#

* add missing underscore prefix to partial (#3840)

mc

* show help shopping button

mc

* start moving FAA to use bootstrap 4 (#3855)

* fix fonts, more ridp work started

* start faa

* fix resolve layout

* fix resolve layout

* fix rebase issues

* pr requests and translations

---------

Signed-off-by: kristinmerbach <[email protected]>

mc

* help me sign up flow bs4 conversion started (#3887)

* help me sign up flow started

* translations and search input

* wave issues

* translations

---------

Signed-off-by: kristinmerbach <[email protected]>

mc

* add document list to verify identity (#3890)

* cleanup, move old list to bs4

* more list work

* layout cleanup

* more list work

* adds trash style

* destroy icon update

* adds js handling for delete

* add new js destroy

* indentation fixes

* adds aria

* use h6 for type

* fix header span

* indentation fixes, update fdish page with list changes as well

* add missing change from merge

* remove class

* refactor row classes to support mobile

* alpha tweak

* remove float-end

* remove align

* fix unmatched span

* remove align

* remove d-flex

* puts label and badge in col

* button refactor

* remove unneeded icon

* add remove padding

* margin fixes

* more layout fixes

* restore fdsh modal

* use insured modal for insured

* cleanup

mc

* merge conflicts

* merge conflicts

* outline for sep page

* more detail work, passes in bs4 flag for date check, implements modal

mc

* add get_date method for date parsing based on bs4 param

* add date formatting for other date param

* localize error text, use progress buttons, shop link in success message

* reset continue button on init, remove line break with bs4

* date input work

* cleanup

* cleanup

* add missing closing tag

* uses correct key for number

* update date entry to be time-based instead of focus

* default continue button to qle_submit, enable it on date entry, update it to submit on date validation

* rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case

* adds bs4 layout for reason partials

* missing label tag

* undo debug line

* indentation fix

* remove unneeded div

* remove uneeded class

* replace values for radio

* remove todo

* cleanup, add zip view for bs4

* update moving handlers to allow for button id switching

* fix bug which allows zip partial to permeate when selecting another link

* localized special reasons

* add modal handling

* localize zip error

* fix modal handler

* move date chose hide

* consolidate check date error case

* further check ql date refactoring

* localize middle of month coverage error string

* localize future error

* refactor get_date helper for clarity

* use var instead of const to avoid redeclaration error

* move id to nav partial

* clean up error arg

* move qle zip id reset

* remove unneeded class

* updates moves bs4 param check for some actions into refactored enable_bs4_layout method

* upgrade to bs4 base

mc

* revert temp changes for design review to trunk

mc

* personal information page redo

mc

* feature flags, faa layouts

mc

mc

* header progress

mc

* add bs4 upgrade icons, collapsed header tweaks

mc

* started family information

mc

mc

* registration process

mc

* more work on consumer flow

mc

* client specific files re-organized

mc

* authority & consent ridp page

mc

* progress nav accessibility

mc

* fix fonts, more ridp work started

mc

* ridp flow

mc

* don't touch FAA yet

mc

mc#

mc

* starting to rubocop

mc

* fix brakeman, other text changes

mc

* reformat devide translations

mc

* id bad bullets

mc

* id bad bullet

mc

* id bad bullet

mc

* previous and continue buttons dryed out

mc

* fix auth and consent previous button layout (#3825)

* wrap progress button in vertically aligned flex box

* combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality

* remove unneeded div

* remove unneeded argument

mc

mc

* add missing underscore prefix to partial (#3840)

mc

* mc show help shopping button

* help me sign up flow bs4 conversion started (#3887)

* help me sign up flow started

* translations and search input

* wave issues

* translations

---------

Signed-off-by: kristinmerbach <[email protected]>

mc

* fix fonts, more ridp work started

* choose cov page wip

mc

* plan shopping progress bars updated

mc

* plan shopping nav refactoring

mc

* family information conversion, fixed progress nav buttons

mc

* translation fixes

* removed debugging code

* rebase cleanup

mc

* fix link_to CSS vunerabilities

mc

* webpacker depreciation warning cleanup

* integrate progress nav into sep

* fix success link to match new id

* add record_sep to bs4 conditionally enabled to account for date parsing

* add modal comment

* rename submit method

* remove sep-form, add sep-date class

* add missing span

* add personal to conditionally enabled

* add missing semi colon

* move date change text set out of js, add calc translation

* add translation to other partial

* rebase clenaup

mc

* more rebase cleanup

* more rebase cleanup

* more rebase cleanup

* renames event label, adds date label

* remove unneeded var

* unbind selector on load

* add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy

* fix enter navigation

* remove unneeded check

* remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer

* removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs

* cleanup

* undo gemfile

* remove debug special case

* remove whitespace

* fix legacy date continue

* move sep-date class up to parent to capture both date field and button

* fix for keydown suppression

* add effective handling

* remove unneeded fields, add label to select

* restore selector for form keydown

* adds missing nav title

* restore kinds check

* remove if debug for moving fields

* remove random semi colon

* use symbols for conditional def

* remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds

* rebase cleanup

* indentation fix

* fixes dangling form labels

* fix keyboard bug preventing all input

* rebase cleanup

* rebase cleanup

* remove style attr

* fix enter press

---------

Co-authored-by: Kristin Merbach <[email protected]>
Co-authored-by: Sarah Austin <[email protected]>
Co-authored-by: kristinmerbach <[email protected]>
@scaustin34
fix missed translations (#3973)
88a5377 
* fix missed translations

* fix rebase chaos
@charlienparker @kristinmerbach
bs4 functional bugfixes (#3978)
5c3640d 
* personal information page redo

mc

* fix for previous button following legacy implementation

* add verify header to service unavailable, use bolded paragraph for try again text

* remove duplicate translation

* add padded template for bs4

* replace label with p tag

* remove required distinction between mailing and home address fieldsets

* center warning icon in exception show

* add glossary class for term

mc

* rebase cleanup

* rebase cleanup

* add required class to all labels regardless of required var

* add missing diff

* update file field tag text to use label, add css for button labels to match button text across app

* add label for non-identity upload button

* remove labels from modal prompt

* comment update

* required cleanup on consumer fields - FA citizen, naturalized, and incarcerated & Consumer incarcerated

* update consumer_signup partial to convert layout args to strings in content_for, remove show_help from personal info edit

* flash fixes

* use gray color instead of white

* remove flash debug

* add bs4 check to glossary

* update exception structure to avoid full underline by breaking out substrings

* fix broken translation file

* update legacy spacing

* call logout for link in nav panel

* fix no match icon alignment

* replace debug, remove duplicated div

* add flag check to layout for step, eligibility response, and application publish error pages

* fix logout link for FA

* fix for duplicate validation alert

---------

Co-authored-by: Kristin Merbach <[email protected]>
@ATBull81 @kristinmerbach
uplift job income page to bs4 (#3974)
e3ce57a 
* personal information page redo

* job income changes

* missing translations

* updates to translation

* cleanup unneeded class changes

* remove extra changed file

* more cleanup

* changes from PR comments

* fixed

* header sizing order issue

* remove br

* small nav bug for nonbs4

* improve spacing

* fix income_kind

* clean up nits

* phone input masking

* more changings

---------

Co-authored-by: Kristin Merbach <[email protected]>
@kristinmerbach
bs4 sidebar refactor (#3985)
57993a3 
* sidebar nav refactor

* translations

* remove unneeded changes

* fix plan shopping nav and remove debug code

---------

Signed-off-by: kristinmerbach <[email protected]>
@ATBull81
small bug fixes, navigation improvements (#3988)
7378e0b 
* small bug fixes, navigation improvements

* member to household translation change

* another translation
@scaustin34 @kristinmerbach
Bs4 faa health coverage page (#3952)
b382f83 
* personal information page redo

* wip faa health cov page

* heavlth cov progress

* coverage card progress, added missing question

* get the non esi functionality working

* started esi benefits

* esi form functionality, more tweaking of the disabling

* translations

* remove rebase issues

* more pr fixes

---------

Co-authored-by: Kristin Merbach <[email protected]>
@kristinmerbach
add missing translations
87439ec
@kristinmerbach
more translations
11135c6
@kristinmerbach
add back the close icons
5d87a8f
@kristinmerbach
sidebar cleanup
4b8dc19
@kristinmerbach
enable future links, properly set completely
b3b32bf
@kristinmerbach
enable future links, properly set completely
ae06fc3
@kristinmerbach
enable future links
e2dc48c
@kristinmerbach
completeness
c628a99
@kristinmerbach
fixed link text
08d0bba
@kristinmerbach
add tavels for security questions
7e6ae0a
@kristinmerbach
updated ridp agreement link text
41341d1
@charlienparker
bs4 income button fixes (#3994)
3d1bcb1 
* fix legacy deduction add button

* add missing button closing tag

* add disabled class for after required, wrap all required legends/labels in spans to capture the inner text

* add missing content for devise email requirement
@scaustin34
dependent address error remove (#3986)
4c3915f 
* remove unecessary error message

* remove uneceaasry modal
@polographer
print cucumber failures in summary (#3987)
7cbff15 
* adding cucumber failures to summary

* trying another way to pipe it

* trying with tee instead of just redirection

* tee didn't work

* print error on screen too
@ATBull81
convert response_id to string
a768b74
@bbodine1
chore: enable previous button in navigation helper
e970ae5
@bbodine1 bbodine1 requested a review from a team as a code owner July 5, 2024 20:29
@bbodine1 bbodine1 self-assigned this Jul 5, 2024
@bbodine1 bbodine1 closed this Jul 5, 2024
@bbodine1 bbodine1 deleted the 187912756/verify-identity-1-previous-step-button-missing branch July 5, 2024 20:32
@bbodine1 bbodine1 restored the 187912756/verify-identity-1-previous-step-button-missing branch July 5, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bbodine1 bbodine1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@bbodine1 @scaustin34 @kristinmerbach @charlienparker @kvootla @ATBull81 @quisbertdiana @anncaballeroo @polographer