update sep page for bs4 #3902
Merged
update sep page for bs4 #3902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlienparker
changed the base branch from
clean-bootstrap-4-upgrade
to
bs4-plan-shopping
charlienparker
changed the base branch from
bs4-plan-shopping
to
clean-bootstrap-4-upgrade
kristinmerbach
force-pushed
the
clean-bootstrap-4-upgrade
branch
from
09dabe0 to
c758192
Compare
kristinmerbach
previously requested changes
Jun 10, 2024
kristinmerbach
force-pushed
the
clean-bootstrap-4-upgrade
branch
from
dc5f57d to
2dfb81c
Compare
scaustin34
approved these changes
Jun 11, 2024
kristinmerbach
force-pushed
the
clean-bootstrap-4-upgrade
branch
from
0ec06d1 to
ecacb27
Compare
scaustin34
force-pushed
the
clean-bootstrap-4-upgrade
branch
from
6ad8ab4 to
49d0dcc
Compare
scaustin34
force-pushed
the
clean-bootstrap-4-upgrade
branch
from
d38df6b to
714bed1
Compare
kristinmerbach
added a commit
that referenced
this pull request
Jul 12, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
ATBull81
pushed a commit
that referenced
this pull request
Jul 19, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Jul 22, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Jul 26, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Jul 30, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Jul 31, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 1, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 2, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 3, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 6, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 7, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 9, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 10, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 13, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 14, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 15, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 16, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 19, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 20, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 20, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 22, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 23, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 27, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 28, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
bbodine1
pushed a commit
that referenced
this pull request
Aug 29, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
kristinmerbach
added a commit
that referenced
this pull request
Sep 4, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
kristinmerbach
added a commit
that referenced
this pull request
Sep 6, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
kristinmerbach
added a commit
that referenced
this pull request
Sep 10, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
charlienparker
added a commit
that referenced
this pull request
Sep 13, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
charlienparker
added a commit
that referenced
this pull request
Sep 16, 2024
* personal information page redo mc * mc * mc * mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc mc * client specific files re-organized mc * footer updates mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * added ME colors, revert app controller flag mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc# * add missing underscore prefix to partial (#3840) mc * show help shopping button mc * start moving FAA to use bootstrap 4 (#3855) * fix fonts, more ridp work started * start faa * fix resolve layout * fix resolve layout * fix rebase issues * pr requests and translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * add document list to verify identity (#3890) * cleanup, move old list to bs4 * more list work * layout cleanup * more list work * adds trash style * destroy icon update * adds js handling for delete * add new js destroy * indentation fixes * adds aria * use h6 for type * fix header span * indentation fixes, update fdish page with list changes as well * add missing change from merge * remove class * refactor row classes to support mobile * alpha tweak * remove float-end * remove align * fix unmatched span * remove align * remove d-flex * puts label and badge in col * button refactor * remove unneeded icon * add remove padding * margin fixes * more layout fixes * restore fdsh modal * use insured modal for insured * cleanup mc * merge conflicts * merge conflicts * outline for sep page * more detail work, passes in bs4 flag for date check, implements modal mc * add get_date method for date parsing based on bs4 param * add date formatting for other date param * localize error text, use progress buttons, shop link in success message * reset continue button on init, remove line break with bs4 * date input work * cleanup * cleanup * add missing closing tag * uses correct key for number * update date entry to be time-based instead of focus * default continue button to qle_submit, enable it on date entry, update it to submit on date validation * rename check_qle_date and get_qle_date methods for clarity, update *_reason js files to update submit id, update reason handler to update submit id and disable button in fail case * adds bs4 layout for reason partials * missing label tag * undo debug line * indentation fix * remove unneeded div * remove uneeded class * replace values for radio * remove todo * cleanup, add zip view for bs4 * update moving handlers to allow for button id switching * fix bug which allows zip partial to permeate when selecting another link * localized special reasons * add modal handling * localize zip error * fix modal handler * move date chose hide * consolidate check date error case * further check ql date refactoring * localize middle of month coverage error string * localize future error * refactor get_date helper for clarity * use var instead of const to avoid redeclaration error * move id to nav partial * clean up error arg * move qle zip id reset * remove unneeded class * updates moves bs4 param check for some actions into refactored enable_bs4_layout method * upgrade to bs4 base mc * revert temp changes for design review to trunk mc * personal information page redo mc * feature flags, faa layouts mc mc * header progress mc * add bs4 upgrade icons, collapsed header tweaks mc * started family information mc mc * registration process mc * more work on consumer flow mc * client specific files re-organized mc * authority & consent ridp page mc * progress nav accessibility mc * fix fonts, more ridp work started mc * ridp flow mc * don't touch FAA yet mc mc# mc * starting to rubocop mc * fix brakeman, other text changes mc * reformat devide translations mc * id bad bullets mc * id bad bullet mc * id bad bullet mc * previous and continue buttons dryed out mc * fix auth and consent previous button layout (#3825) * wrap progress button in vertically aligned flex box * combines prev and continue link partial into one partial, updates consumers of the old partials to use the new one and keep functionality * remove unneeded div * remove unneeded argument mc mc * add missing underscore prefix to partial (#3840) mc * mc show help shopping button * help me sign up flow bs4 conversion started (#3887) * help me sign up flow started * translations and search input * wave issues * translations --------- Signed-off-by: kristinmerbach <[email protected]> mc * fix fonts, more ridp work started * choose cov page wip mc * plan shopping progress bars updated mc * plan shopping nav refactoring mc * family information conversion, fixed progress nav buttons mc * translation fixes * removed debugging code * rebase cleanup mc * fix link_to CSS vunerabilities mc * webpacker depreciation warning cleanup * integrate progress nav into sep * fix success link to match new id * add record_sep to bs4 conditionally enabled to account for date parsing * add modal comment * rename submit method * remove sep-form, add sep-date class * add missing span * add personal to conditionally enabled * add missing semi colon * move date change text set out of js, add calc translation * add translation to other partial * rebase clenaup mc * more rebase cleanup * more rebase cleanup * more rebase cleanup * renames event label, adds date label * remove unneeded var * unbind selector on load * add bs4 qle_submit handler, add missing zip submit handler that was also missing in legacy * fix enter navigation * remove unneeded check * remove enter keydown from qle for bs4, move moving id reset out of completion, remove typing timer * removes button id switching, adds button partials to each special reason partial, and details landing/date/error/success divs * cleanup * undo gemfile * remove debug special case * remove whitespace * fix legacy date continue * move sep-date class up to parent to capture both date field and button * fix for keydown suppression * add effective handling * remove unneeded fields, add label to select * restore selector for form keydown * adds missing nav title * restore kinds check * remove if debug for moving fields * remove random semi colon * use symbols for conditional def * remove extraneous param for button partial, update effective on kinds setup to only disable submit button when there are multiple kinds * rebase cleanup * indentation fix * fixes dangling form labels * fix keyboard bug preventing all input * rebase cleanup * rebase cleanup * remove style attr * fix enter press --------- Co-authored-by: Kristin Merbach <[email protected]> Co-authored-by: Sarah Austin <[email protected]> Co-authored-by: kristinmerbach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements
PR Type
What kind of change does this PR introduce?
What is the ticket # detailing the issue?
Ticket: https://www.pivotaltracker.com/story/show/187141791
A brief description of the changes
Current behavior: SEP page is using old UI with the BS4 flag on.
New behavior: SEP page is now using the new UI with the BS4 flag on.
Notes
This PR updates the UI for the Special Enrollment Period page following the new mockups. Several controller methods are updated, including:
find_sep: This action drives the page wholesale, and it passes down the BS4 flag for driving the new page.check_qle_date: This is a helper action which verifies the date parameter. The new UI passes up a different date format for the date selector, and as such a hidden field for the BS4 flag is used to drive the call inqle.jsso that the format can be properly parsed. Additionally, this flag is passed down to its js file to switch between the legacy and BS4 versions of theerrorNotice.check_insurance_reason,check_move_reason,check_insurance_reason: These are helper actions called by theqle_detailpartial in theqle.jsfile used for checking these special reasons. These three methods may also render their own dedicated partials, for which these methods also pass down the BS4 flag for driving the new UI.record_sep: This action performs the POST for SEP selection before redirecting to plan selection. It also formats the date, and as such, also relies on the hidden field for BS4 to drive the date formatting.Legacy SEP displayed additional fields for special reasons along with another continue button. New SEP will only ever display the Previous/Continue to Next Step buttons, where each special reason partial owns its own
progress_navigation_buttonspartial. This also includes the Date, Success, and Error divs withinfind_sep. On the landing page, a "dummy" set of buttons is displayed with the Continue to Next Step button being hardcoded to disabled. Additionally, the Date div will start with its Continue to Next Step button as disabled, andqle.jswill enable it once the date field is updated with input.I also refactored some of the JS to be more readable, like the function names in
qle.js, and the repeated logic incheck_qle_date.js.